kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

On 08/08/2016 06:09 PM, Wayne Stambaugh wrote:
> The last time I looked, notifications of repo commits still were not
> implemented.  This is a show stopper for me.  I don't want to have to
> constantly grep the git commit log to see what changed.  If change
> notifications are working correctly, then I'm OK with moving forward on
> this if you can get the bug fix linking working.  We definitely should
> do some testing before we go live with this.

I see there is an option to set notifications, in the same way as for
the bazaar branches ("Edit your subscriptions" on the right side pane).
I could not verify it, as likely I cannot receive notifications for the
changes I introduce. Even if it does not work, I can implement it in my
webhook.

The webhook has reached beta stage. I have created a dummy project for
testing purposes, where you can see a bug report [1] and a commit [2]
with message that includes a "fix(es)?[ ]+(lp:|#)?([0-9]+)" regex match.
When it is detected, it automatically adds a message, changes the bug
status and assignee. One thing that is not possible right now is linking
with git branches, as apparently launchpad does not handle this at the
moment (or I could not find the right format to specify a branch).

All we need to do is to set a webhook pointing to my script [3]. If it
is accepted, then I am going to create a separate lp account for the
automated changes.

Currently the webhook works on my home server which has a high uptime,
but still it is not as reliable as dedicated servers. If there is
someone willing to host it on a better machine, I will be pleased to help.

If you are curious about the source code, then I can put it in the KiCad
github (once I get a repository there) or just post it somewhere.

Regards,
Orson

1. https://bugs.launchpad.net/kicad-git-test/+bug/1611664
2.
https://git.launchpad.net/kicad-git-test/commit/?id=3d29b9be29346fdfaa87cdf8abf6957bf46bb5cd
3. https://orson.net.pl/kicad_git_hook

> Before every starts beating the GitHub drum, I have one major issue with
> GitHub and that is control.  There is no way that I know of to moderate
> a project on github.  Anyone with a github account can submit a pull
> requests at anytime even if they are not part of the dev team.  As
> project leader, this is an issue.  I'm already a my limit with the
> development team we have in place and I really don't want to deal with a
> wide open code hosting.  I also have no way of removing someone from the
> list should I need to.  I know it hasn't happened yet but I am not naive
> enough to think that it wont happen.  At this time, I am more
> comfortable with LP until something better comes along or we take full
> control a provide our own hosting.
> 
> On 8/8/2016 3:58 AM, Maciej Sumiński wrote:
>> Apparently we have not discussed git transition for a long time now, so
>> I felt it is the right time to raise the subject again to keep our routine.
>>
>> Launchpad now supports merge proposals [1] and it looks like they are
>> still improving git integration. The only missing feature are links
>> between bug fixing commits and respective bug reports (bzr commit ...
>> --fixes=lp:123456). It is not supported by git itself, but might be
>> resolved using webhooks [2] and appropriate keywords in commit messages
>> (e.g. "Fixed a memory leak [fixes #123456]"). If this is the only
>> obstacle, then I volunteer to provide code for the hook.
>>
>> What do you think? Is there anything else that prevents transition?
>>
>> Regards,
>> Orson
>>
>> 1. https://help.launchpad.net/Code/Git
>> 2. https://help.launchpad.net/API/Webhooks
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature