kicad-developers team mailing list archive

[Heikki Pulkkinen <hei6mail@xxxxxxxxx>]

Hi,

Putting back that my via stitching tool to routing tool. It is better that
way, I think. All via tools are in same place, and it adds vias to pours
only from hotkeys.



On Sun, Oct 2, 2016 at 12:28 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
wrote:

> Hi,
>
> Finally Via Stitching without tracks is at zone tool. I tested it little
> bit, but more tests are needed. This patch replace all other patches. Do
> not use them, use only this patch. I think this is worth of try. I am going
> to use it anyway, even if it do not get any acceptance. First patch is for
> Fedora users. It makes possible to build Kicad in Fedora release wxWidgets
> libs whitout building wxWidget from source. I do not know has anybody else
> that problem, but I had.
>
>
> Heikki
>
> On Tue, Sep 27, 2016 at 6:46 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
> wrote:
>
>> Hi
>>
>> And I really practice. I made improvement and forgot to copy all. So
>> improvement is in these two patches. I hope this suggestion is accepted as
>> a new feature.
>>
>> Heikki
>>
>> On Tue, Sep 27, 2016 at 2:31 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>> wrote:
>>
>>> Hi,
>>>
>>> As in  practice, I made a patch file of my changes Not only diifs. It is
>>> SHIFT-ALT-V hotkey whitch make buried and blind vias, as it is in routing
>>> too.
>>>
>>>
>>> Heikki
>>>
>>> On Sun, Sep 25, 2016 at 2:25 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I made some improvements to my patch of via stitching. Now you can just
>>>> point copper pour place and press V, it make trough via. If you press
>>>> SHIFT+CTRL+V it make buried or blind via.It does not change working layer.
>>>> Only when you place buried or blind via from different layer than it's
>>>> layer pair is. I think that it is quite easy to shoot board full of copper
>>>> pours connecting vias. It is possible to remove connecting tracks from old
>>>> designs. Just delete connection from pad and use clenup. Only have to
>>>> remember that if there are not at least two copper pours in same netcode in
>>>> different layers via is deleted too. Any support?
>>>>
>>>>
>>>> Heikki
>>>>
>>>> On Sat, Sep 24, 2016 at 3:06 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> Hi everybody,
>>>>>
>>>>> This is my suggestion to via stitching without any tracks. It connects
>>>>> unconnected vias in different copper pours witch has same netcode. Adding
>>>>> vias is normal routing process without routing tracks. Start - Change Layer
>>>>> - End. Tool that do those things automatically would be good, so you can
>>>>> add all vias in same layer. After adding vias, run "Fill or Refill All
>>>>> Zones" that "Clenup tracks and vias" do not remove partly connected vias.
>>>>>
>>>>>
>>>>> Heikki
>>>>>
>>>>
>>>>
>>>
>>
>

From 69095a9276f557be290b1028f886c6d659b8d23b Mon Sep 17 00:00:00 2001
From: heikki <hei6mail@xxxxxxxxx>
Date: Tue, 4 Oct 2016 11:41:29 +0300
Subject: [PATCH 4/6] Via Stitching back to route tool
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------2.7.4"

This is a multi-part message in MIME format.
--------------2.7.4
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 pcbnew/hotkeys_board_editor.cpp |  2 +-
 pcbnew/onrightclick.cpp         | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)


--------------2.7.4
Content-Type: text/x-patch; name="0004-Via-Stitching-back-to-route-tool.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0004-Via-Stitching-back-to-route-tool.patch"

diff --git a/pcbnew/hotkeys_board_editor.cpp b/pcbnew/hotkeys_board_editor.cpp
index 1f152b9..965ffdf 100644
--- a/pcbnew/hotkeys_board_editor.cpp
+++ b/pcbnew/hotkeys_board_editor.cpp
@@ -373,7 +373,7 @@ bool PCB_EDIT_FRAME::OnHotKey( wxDC* aDC, int aHotkeyCode, const wxPoint& aPosit
         if( !itemCurrentlyEdited ) // no track in progress: switch layer only
         {
             //Add via with stitching
-            if( GetToolId() == ID_PCB_ZONES_BUTT )
+            if( GetToolId() == ID_TRACK_BUTT )
             {
                 evt_type = hk_id == HK_ADD_BLIND_BURIED_VIA ?
                 ID_POPUP_PCB_PLACE_ZONE_BLIND_BURIED_VIA : ID_POPUP_PCB_PLACE_ZONE_THROUGH_VIA;
diff --git a/pcbnew/onrightclick.cpp b/pcbnew/onrightclick.cpp
index d3d6b90..f5ed5d0 100644
--- a/pcbnew/onrightclick.cpp
+++ b/pcbnew/onrightclick.cpp
@@ -367,18 +367,6 @@ bool PCB_EDIT_FRAME::OnRightClick( const wxPoint& aMousePos, wxMenu* aPopMenu )
                                  g_Board_Editor_Hokeys_Descr, HK_ZONE_REMOVE_FILLED );
             AddMenuItem( aPopMenu, ID_POPUP_PCB_REMOVE_FILLED_AREAS_IN_ALL_ZONES,
                          msg, KiBitmap( zone_unfill_xpm ) );
-
-            msg = AddHotkeyName( _( "Place Through Stitch Via" ), g_Board_Editor_Hokeys_Descr,
-                                 HK_ADD_THROUGH_VIA );
-            AddMenuItem( aPopMenu, ID_POPUP_PCB_PLACE_ZONE_THROUGH_VIA, msg, KiBitmap( via_xpm ) );
-            if( GetDesignSettings().m_BlindBuriedViaAllowed )
-            {
-                msg = AddHotkeyName( _( "Place Blind/Buried Stitch Via" ),
-                                    g_Board_Editor_Hokeys_Descr, HK_ADD_BLIND_BURIED_VIA );
-                AddMenuItem( aPopMenu, ID_POPUP_PCB_PLACE_ZONE_BLIND_BURIED_VIA, 
-                             msg, KiBitmap( via_buried_xpm ) );
-            }
-
             aPopMenu->AppendSeparator();
         }
 

--------------2.7.4--