← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] CPolyLine -> SHAPE_POLY_SET refactor

 

Le 30/01/2017 à 22:30, Alejandro Garcia Montoro a écrit :
> 
> I've pushed a polygon-refactor branch on my own repo, see [1].
>  
> 
>     Developers, please review and test this patch as thoroughly as possible
>     and give feedback to Alejandro.  Once we are comfortable that it is good
>     to go, we can merge it into master.
> 
>     I probably wont get time to review it this week since I'm leaving for
>     FOSDEM Thursday.  I will try to get to it as soon as possible after I
>     get back.

Hi Alejandro,

I made a quick test of the polygon-refactor branch.

I encountered a few issues (both on W7 and Linux)

* a minor issue in /a/geometry/CMakeLists.txt:
The add_dependencies is missing: something like add_dependencies( qa_geometry pcbnew ) is needed.

* In GAL canvas, depending on the zoom level and the size of the filled zones areas, filled zones
areas are displayed or not.
Same for zone outlines.

* When refilling a zone, the filled area is broken, and covers tracks and pads.
Strangely, some obstacles like texts on copper layers and lines on edge-cut layers are not covered.

* there are also some issues in legacy mode, when trying to edit a zone outline.

Also please, update you working branch to the latest master version: I fixed an annoying issue.

Thanks.

-- 
Jean-Pierre CHARRAS


Follow ups

References