kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I just checked and it's the revision parsing code.  I will either have
to create a SYMBOL_LIB_ID from LIB_ID and overload
LIB_ID::SetLibItemName() or just remove the version parsing from LIB_ID.
 I wont have time to look at this until tomorrow afternoon so if you
need to get some work done, please revert to an earlier build.  Thanks
for the info.

On 2/10/2017 6:52 PM, José Ignacio wrote:
> In any case this will break backwards compatibility in a way it did not
> happen in PCBnew, EEschema always looks for symbols in libraries
> (including the cache) when loading a file (there are no embedded symbols
> to fall back to), so suddenly making certain names not resolve will
> cause schematics to break upon opening. To avoid breaking previous
> designs either a special case needs to be done for the cache (my least
> favourite option), or like Chris says, let each plugin define what's
> legal or not.
> 
> On Fri, Feb 10, 2017 at 5:37 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     This is a direct result of LIB_ID which has to be used for symbol
>     library mapping.  I could silently force slashes to underscores or some
>     other valid file name character.  I'm sure that is not going to make
>     folks happy but it will have to happen when we convert the legacy symbol
>     libraries to the new format.  We went through the same issue when we
>     converted the footprint libraries as well.  I'll see if I can come up
>     with a work around for the legacy parser but this is only temporary.
> 
>     Was it our microchip libs that are the problem or someone's custom lib?
>     If it's a custom lib, please attach the lib causing the issues so I can
>     debug it.
> 
>     On 2/10/2017 5:42 PM, Nick Østergaard wrote:
>     > I did notice that the new io manager thing broke some libs things
>     > related to the microchip libs, but it also found an error in the
>     > official libs that I patched. But then I forgot to report the other
>     > issues.
>     >
>     > But yeah, it seems strange that slash'es are not allowed in footprint
>     > property names.
>     >
>     > 2017-02-10 22:59 GMT+01:00 Chris Pavlina <pavlina.chris@xxxxxxxxx
>     <mailto:pavlina.chris@xxxxxxxxx>>:
>     >> To elaborate - I get that / is forbidden because part names will
>     be file
>     >> names in the new format, but this is going to break libraries. Manufs
>     >> have used all kinds of horrid symbols in part numbers. Perhaps we
>     should
>     >> make the plugin system allow each plugin to specify its own valid
>     >> characters? The legacy format has always allowed / so the legacy
>     plugin
>     >> should.
>     >>
>     >> On Fri, Feb 10, 2017 at 03:57:11PM -0600, José Ignacio wrote:
>     >>> This broke all my designs with microchip parts (which have
>     forward slashes
>     >>> in the symbol names). Sadpanda.jpg
>     >>>
>     >>> On Fri, Feb 10, 2017 at 8:55 AM, Wayne Stambaugh
>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>     >>> wrote:
>     >>>
>     >>>> I just pushed my changes to make the schematic I/O plugin the
>     default
>     >>>> for all schematic and symbol library I/O.  This is a pretty
>     significant
>     >>>> change.  I tested everything I could think of but there may be some
>     >>>> corner cases that I missed.  I also used LIB_ID instead of
>     wxString to
>     >>>> store symbol library lookup information.  For now, it behaves
>     the same
>     >>>> way it always has.  Please let me know if you find any issues
>     and I will
>     >>>> try to fix them as quickly as possible. 
>     KICAD_USE_SCH_IO_MANAGER is no
>     >>>> longer a build option.
>     >>>>
>     >>>> I'm going to try to get the symbol library table implemented in
>     the next
>     >>>> week or so.  This will likely be the last of the schematic I/O
>     changes
>     >>>> before the next stable release.  I am going to push the new
>     file formats
>     >>>> to the stable 6 release due to the increasing amount of time I am
>     >>>> spending doing project management stuff and the equally decreasing
>     >>>> amount of time I have to code.  Given that none of the new features
>     >>>> provided by the new file formats would have been implemented
>     for the
>     >>>> stable 5 release, I don't think this is a major setback.  This
>     will give
>     >>>> us some more time to further discuss the new file formats before I
>     >>>> implement them.  The new file formats will be my first task
>     after the
>     >>>> stable 5 release.
>     >>>>
>     >>>> Cheers,
>     >>>>
>     >>>> Wayne
>     >>>>
>     >>>> _______________________________________________
>     >>>> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >>>> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >>>> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >>>>
>     >>
>     >>
>     >> _______________________________________________
>     >> Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     >> Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     >> More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
>     >
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
>