← Back to team overview

kicad-developers team mailing list archive

Re: Question about VIEW_GROUP drawing


Orson, zostaw jakies bugi dla mnie :p btw. Co mulilo opengl? :D

Sent from my Samsung Galaxy smartphone.

-------- Original message --------
From: Maciej Suminski <maciej.suminski@xxxxxxx>
Date: 12/03/2017 22:10 (GMT+01:00)
To: KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Kicad-developers] Question about VIEW_GROUP drawing

Hi Jon,

Wow, the progress on gerbview is amazing. I must admit this is the first
time I compiled it, but it works quite well.

For SELECTION class ViewBBox() is overridden. It computes the bounding
box size depending on its contents. Apart from that, SELECTION object is
added to VIEW during SELECTION_TOOL initialization, without any objects
inside, so the bounding box is not calculated properly. It is also never
updated, therefore you see the selected objects randomly.

You were simply unlucky, as the bug was introduced in the master branch
(dda51ab5) and resolved a few commits later (cc3d79f9). Probably
rebasing your code on the current master will cure the problem. If it is
not the case, please let me know and I will investigate it further.

Recently I have also found the reason why OpenGL was going much slower
than expected. It is fixed now (737dc204), so there is another another
reason to rebase the code.

Thank you for your work on KiCad, we really appreciate it!


On 03/11/2017 10:48 PM, Jon Evans wrote:
> Hi, I guess this is mostly a question for Orson but maybe others could
> answer also...
> I'm chasing a bug that I can't figure out.  I have implemented selection of
> items in GerbView, in a similar mechanism to Pcbnew where selected objects
> are added to a VIEW_GROUP so they are drawn together.  The problem is, the
> VIEW_GROUP is not drawn at all unless I zoom out very far!  I am curious
> what could cause this.  The BBox for VIEW_GROUP is set to the maximum size,
> so it shouldn't ever get culled from the draw list.  So, my other thought
> was that this has something to do with caching, and when I zoom out far
> enough, sure enough, I can see in the debugger that the VIEW_GROUP is now
> drawn in Immediate mode, not cached mode.
> I have not yet wrapped my head around the caching systems in GAL.  Anyone
> know what could be wrong? I guess I'm likely just not configuring something
> properly because this works fine in Pcbnew.
> Thanks,
> Jon

Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp