kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #30619
Re: Loaded Eagle library always cleared after loading since rev a3fc0ef
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Thu, 7 Sep 2017 14:51:13 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.50) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<7e12861c-9f8c-67a6-a06b-e570eb850117@wanadoo.fr>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0
Hi Jean-Pierre,
Thank you for the notice. I checked the code, and I think your proposal
is valid. I have already pushed a patch to fix the problem.
Regards,
Orson
On 09/07/2017 09:04 AM, jp charras wrote:
> Hi Orson,
>
> Could you have a look into your commit a3fc0ef658db69d601f7c91e41c91f43880c1ab0?
>
> It fixes a memory leak by adding and calling deleteTemplates() which delete the footprint list in
> memory.
>
> However, because it is called each time EAGLE_PLUGIN::init is called, the loaded library is in fact
> cleared as soon as you want to load a footprint (for instance in footprint viewer)
>
> My opinion is deleteTemplates() should not be called inside init(), but I am not very familiar with
> the Eagle plugin code, so I let you to fix this issue.
>
> Thanks.
>
References
