← Back to team overview

kicad-developers team mailing list archive

Re: disable icons in menus by default on osx

 

Doesn't matter to me (although I personally always turn them off). I was
just pointing out that the code didn't appear to work as it was intended to
on macOS and provided an alternative.

Michael

On 12 September 2017 at 16:28, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> Do we really need to change the default?  All this will do is change
> which group of users complains about the default setting.  The reason we
> changed this is that some users wanted the menu bitmaps even on
> platforms where it is recommended not to use them.  I just don't see any
> benefit to making this change.  Is it that difficult for users to check
> or uncheck the menu bitmap setting according to their preference?
>
> Wayne
>
> On 9/12/2017 8:56 AM, Fabrizio Tappero wrote:
> > Hi Diogo,
> > thanks for point it our. This has been fixed in a patch that is
> > currently in the pipeline.
> >
> > Cheers
> > Fabrizio
> >
> >
> > On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço <diogocondeco@xxxxxxxxx
> > <mailto:diogocondeco@xxxxxxxxx>> wrote:
> >
> >     While personally I won't use icons in the menus if that option is
> >     available to me, I can see why someone would like to use them.
> >
> >     I can see it being useful to identify actions visually, but with
> >     that in mind, I can't understand why having icons and reusing them
> >     on different functions would help anyone. I've attached a screenshot
> >     where the same icon is used for 3 different actions....
> >
> >     BR,
> >     Diogo
> >
> >     On Thu, Sep 7, 2017 at 3:59 PM, Miguel Angel Ajo Pelayo
> >     <majopela@xxxxxxxxxx <mailto:majopela@xxxxxxxxxx>> wrote:
> >
> >         I personally (as a user) find the icons visually more intuitive.
> >         Specially for newcomers and better adoption of KiCad.
> >
> >         I know it's out of some guidelines, but this is a very complex
> >         software.
> >
> >         My feeling is that it's better with a "on" by default setting,
> >         as long as people already used to the software, or not liking
> >         icons could disable them.
> >
> >         On Thu, Sep 7, 2017 at 4:34 PM, Michael Kavanagh
> >         <michael@xxxxxxxxxxxxxxxxxx <mailto:michael@xxxxxxxxxxxxxxxxxx>>
> >         wrote:
> >
> >             Hi,
> >
> >             Sorry to bring this up again, but for me icons are still
> >             enabled by default on macOS (and Windows unsurprisingly). I
> >             deleted /Library/Application Support/kicad,
> >             ~/Library/Preferences/kicad and /Applications/Kicad,
> >             reinstalled from most recent nightly (07-Sep-2017) and the
> >             icons were there upon startup.
> >
> >             I think the problem was the default value was true when the
> >             key wasn't found (ie for new install),
> >             see http://docs.wxwidgets.org/trunk/classwx_config_base.
> html#a93b700301e0b73f1b42f14497f2e6bc7
> >             <http://docs.wxwidgets.org/trunk/classwx_config_base.html#
> a93b700301e0b73f1b42f14497f2e6bc7>
> >
> >             I have attached a patch to turn icons off by default on all
> >             platforms (doing away with "ugly" #if defined()/#endif). I
> >             think this would be preferable as per both the macOS and
> >             Windows guidelines. I am unfamiliar with Linux UI's but if
> >             Linux users want the icons enabled by default the #if will
> >             have to be added again.
> >
> >             Cheers,
> >             Michael
> >
> >
> >             On 13 April 2017 at 18:51, Wayne Stambaugh
> >             <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> >                 Simon,
> >
> >                 I committed your patch since osx expects the icons to be
> >                 disabled by
> >                 default.
> >
> >                 Thanks,
> >
> >                 Wayne
> >
> >                 On 4/8/2017 6:42 AM, Simon Wells wrote:
> >                 > Please see attached patch to disable icons in the
> menus by default on osx
> >                 >
> >                 >
> >                 >
> >                 > _______________________________________________
> >                 > Mailing list: https://launchpad.net/~kicad-developers
> >                 <https://launchpad.net/~kicad-developers>
> >                 > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >                 <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >                 > Unsubscribe : https://launchpad.net/~kicad-developers
> >                 <https://launchpad.net/~kicad-developers>
> >                 > More help   : https://help.launchpad.net/ListHelp
> >                 <https://help.launchpad.net/ListHelp>
> >                 >
> >
> >                 _______________________________________________
> >                 Mailing list: https://launchpad.net/~kicad-developers
> >                 <https://launchpad.net/~kicad-developers>
> >                 Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >                 <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >                 Unsubscribe : https://launchpad.net/~kicad-developers
> >                 <https://launchpad.net/~kicad-developers>
> >                 More help   : https://help.launchpad.net/ListHelp
> >                 <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >             _______________________________________________
> >             Mailing list: https://launchpad.net/~kicad-developers
> >             <https://launchpad.net/~kicad-developers>
> >             Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >             Unsubscribe : https://launchpad.net/~kicad-developers
> >             <https://launchpad.net/~kicad-developers>
> >             More help   : https://help.launchpad.net/ListHelp
> >             <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >         _______________________________________________
> >         Mailing list: https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/~kicad-developers>
> >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >         Unsubscribe : https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/~kicad-developers>
> >         More help   : https://help.launchpad.net/ListHelp
> >         <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> >     --
> >     Diogo Condeço
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/~kicad-developers>
> >     More help   : https://help.launchpad.net/ListHelp
> >     <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References