Hi Seth,
I noticed in that commit some test data to tools/utf8_test.cpp.
However, the "Utf8AndWx" test case in qa_common doesn't work with
Unicode in the input string.
Doing a quick check back, this never worked, but wasn't covered in the
tests, which only used ASCII literals for the conversion/equality
tests.
Here's a demo patch for the failing tests (adds a test for conversion
of ASCII-only and UTF8 strings, the second one fails). Maybe I'm
holding it wrong, but it seems to me this should work:
#define UTF8_LITERAL "This is a test of UTF-8: ü‱☺😕😱"
// Why so serious?
UTF8 utf8_inited { UTF8_LITERAL };
wxString wx_inited { UTF8_LITERAL };
wxString wx_copied_from_utf8 = utf8_inited;
BOOST_CHECK_EQUAL( wx_inited, wx_copied_from_utf8 );
Cheers,
John
