kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

John,

Does this mean that I do not have to merge 0001-CMake-tools-after-qa.patch?

I'm wondering if it be more prudent to just move the tools/io_benchmark
tests into qa to prevent the build dependency issues.

On 10/24/2018 11:16 AM, John Beard wrote:
> Hi,
> 
> It looks that was actually caused by /qa being ignored in MSVC. This
> has been undone, and now MSVC builds, so looks like we have all green
> builds!
> 
> This probably works now because the following are, recently, commented out:
> 
> # add_subdirectory( pcb_test_window )
> # add_subdirectory( polygon_triangulation )
> # add_subdirectory( polygon_generator )

Why were these commented out?  Do they now fail and need to be fixed?  I
don't think commenting out qa tests is very good fix.

> 
> So whatever was previously broken there is no longer even built on any
> platform, and thus doesn't break the build.
> 
> Cheers,
> 
> John
> On Wed, Oct 24, 2018 at 12:48 PM John Beard <john.j.beard@xxxxxxxxx> wrote:
>>
>> Hi all,
>>
>> There's also (groan) an MSVC failure here. The includes for the file
>> in the new qa_utils lib aren't picked up, so it fails. The includes
>> *are* in my Linux build and are evidently also in the Mac/Mingw builds
>> as they work too. Could this be related to the top-level CMakeLists,
>> which goes "tools, utils, qa", but "tools/io_benchmark" relies on
>> "qa/qa_utils"?
>>
>> In which case does flipping the CMake add_subdirectory order work
>> (attached patch).
>>
>> If this *does* work, any clues as to why only MSVC cares?
>>
>> Would it be better to put io_benchmark in to the qa folder anyway?
>>
>> Cheers,
>>
>> John
>> On Wed, Oct 24, 2018 at 12:20 AM Adam Wolf
>> <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
>>>
>>> The Mac build was broken last night, a rebuild this morning didn't help, but I'll trigger another one now and see how it goes.
>>>
>>> Thanks folks!
>>>
>>> On Tue, Oct 23, 2018, 5:44 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>>
>>>> Fixes the linux build.  Yeah!!
>>>>
>>>> On 10/23/18 6:37 PM, Seth Hillbrand wrote:
>>>>> Am 2018-10-23 17:48, schrieb Jeff Young:
>>>>>>> … Let's just hope the macos build doesn't choke.
>>>>>>
>>>>>> He he.  And it did. :)
>>>>>>
>>>>>> I think I fixed it but someone might want to check that I didn’t do
>>>>>> something stupid.
>>>>>>
>>>>>> https://git.launchpad.net/kicad/commit/?id=4061f1cce3b177ceca894fd2f01e0eedd928273b
>>>>>>
>>>>>
>>>>> Just needed a little tweak
>>>>>
>>>>> Best-
>>>>> Seth
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp