← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fuzzable PCB parsing test harness


On Wed, Oct 24, 2018 at 4:21 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> Does this mean that I do not have to merge 0001-CMake-tools-after-qa.patch?

Correct. That patch does *not* need to be merged. master currently
appears to build correctly.

> I'm wondering if it be more prudent to just move the tools/io_benchmark
> tests into qa to prevent the build dependency issues.

This wasn't actually a dependency issue in the end, more a config
issue on the MSVC builder side. I don't really know where tools ends
and qa begins. I think io_benchmark could happily live in either.

> Why were these commented out?  Do they now fail and need to be fixed?  I don't think commenting out qa tests is very good fix.

They were commented out in e439b17fa as part of the eeschema GAL merge.



Follow ups