kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

John,

AFAICT, this fixes the issue so I pushed your patch.

Thanks,

Wayne

On 1/4/19 9:11 AM, John Beard wrote:
> Hi Alexis,
> 
> Sorry about that - it's been on my list for a while. I misunderstood
> how the GAL inits without config. Hopefully this will work. Patch
> attached: the upshot is that legacy should never even be tried in a
> blank-config startup now, even if the platform supports it (as this
> will be the behaviour in future anyway, when legacy is gone).
> 
> GAL wizards please comment if I have got it wrong again!
> 
> Cheers,
> 
> John
> 
> On Fri, Jan 4, 2019 at 3:43 AM Alex Lockwood <alexlockwood@xxxxxxxxxxxx> wrote:
>>
>> Yup. Okay, thanks - I need to pay more attention the bug tracker before
>> whinging on the list.
>>
>> On Thu, Jan 03, 2019 at 10:13:25PM -0500, Seth Hillbrand wrote:
>>> Am 2019-01-03 21:27, schrieb Alex Lockwood:
>>>> Hey, has anyone started pcbnew with nothing in ~/.config/kicad recently?
>>>> I just did, and loaded a project, and this is what I got:
>>>>
>>>> https://misc.c4757p.com/wtfpcbnew.png
>>>>
>>>> I had to manually set the canvas from inside pcbnew. Otherwise the
>>>> rendering was completely screwed up, everything piled on top of
>>>> everything in a way that I couldn't even really tell what was going on.
>>>> Uninitialized setting somewhere, maybe? It's entirely possible this is
>>>> specific to this machine, I also haven't started from clean in a long
>>>> time. Just curious whether anyone's testing those code paths.
>>>>
>>>> I also had to apply this patch to keep pcbnew from segfaulting when I
>>>> open menus. Suppose I should probably open a proper bug for this one,
>>>> but I'm a bit confused by it (it seems like this should have been broken
>>>> for a long time for everyone, but it...isn't?)
>>>>
>>>> diff --git a/pcbnew/pcb_base_frame.cpp b/pcbnew/pcb_base_frame.cpp
>>>> index 36ffbd45f..c663f8a60 100644
>>>> --- a/pcbnew/pcb_base_frame.cpp
>>>> +++ b/pcbnew/pcb_base_frame.cpp
>>>> @@ -1189,7 +1189,7 @@ void PCB_BASE_FRAME::OnUpdateSwitchCanvas(
>>>> wxUpdateUIEvent& aEvent )
>>>>      for( auto ii: menuList )
>>>>      {
>>>>          wxMenuItem* item = menuBar->FindItem( ii.menuId );
>>>> -        if( ii.galType == canvasType )
>>>> +        if( item && ii.galType == canvasType )
>>>>              item->Check( true );
>>>>      }
>>>>  }
>>>
>>> I think that this is the same as [1] that John is working on.  Are you using
>>> GTK3?
>>>
>>> [1]https://bugs.launchpad.net/kicad/+bug/1809997
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp