kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #39401
Re: [patch] GAL pixel alignment
-
To:
Jeff Young <jeff@xxxxxxxxx>, Seth Hillbrand <seth@xxxxxxxxxxxxx>
-
From:
Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
-
Date:
Mon, 11 Feb 2019 22:57:04 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Autocrypt:
addr=tomasz.wlostowski@xxxxxxx; prefer-encrypt=mutual; keydata= mQINBFRh3ssBEADmCSrn6qwXrSwI2/LcFSv0aXNHrUQ0MyOAHAW1Rn3LNXLcSCxep1w0iH8q M+ag0XxRVf87DGqjv8wKLGc8nIkGtrMSOuiF+hsrtjAiIrOyOipTABLapqGVj1Dm/26NCtiM /0ZU3XjKcSS5rrj4epKaTM0qW7xp6VceZgH79MbiSCjrt/r9Yhx4tGbWBaCSgTOUHwNB3/Oq 0E5VjU5SAQBQhwG71mES/xaIIUxtfxAPLxpvaq81cjTuT2VQ30T65fSDVikwXrc7M/a2hUG0 nyreo4CktY4pazofQpBA8f8gDPOY1CezY1o1or1Ey6Td/YM/G/Q2G9RZZTjPgD1KRdWIC+nG oCP0lcrMh8Ee+JgR2X7iAAfyVuKAeokxkGnCLon2qiuRG6yAGsEeunJDSd0XtBXzn71GqQH6 0NJzndNoI2PptbHMgc6bINbODkl/RFjVLVGMxDQbgxui2inpjayUZVCQ6SHiiY8BMJrpvTWK GvmgXllxGw+9IQ51u/I0W6hBdy0W/P2oXrP7V2GPDdvyIGJaecjvbkEnD1AbRvxlOjVTGFnC cW08ohzNHGfQK/MXaIpnZAWzRqJz8Wx13KkrdN1hT5quJtaHsvuxBclgHmzbqLlfvLnU7iOa tdN/JzL4L3czEFLJhnHOf9e5zd8yith9vGLUwPxjCzQvz5kBEQARAQABtC1Ub21hc3ogV2xv c3Rvd3NraSA8dG9tYXN6Lndsb3N0b3dza2lAY2Vybi5jaD6JAj4EEwECACgFAlRh3ssCGyMF CQlmAYAGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEMD02zLS2+sBdxkQAM3Nwk6cU8JT A0uR83NsQEUWjoGboIkVtO5amqWqWGLBguolhEt/NTuzQtmD6rFFhPcOpXDKRKdd6ySdlUB7 8XIgQQTEex6uQpWWV/cLACz6a0u0BONA+VPFzRpWSpOMKpCOcm7izGX9H4CZu4f+bqhL3zaC 38Ki5XxyyioGUzyWd/tw84nz2JgrP1zcYih0Qq82ooO1sRIUrJrm7onb4dH29p7d12uGiQZt go+xeYcDW3TlN4m2tmd7l/JqsD8F0CqtvWrGMsdbr1NE5Y2vyIpG3rkkCiTrlUs0SFyqAC7L qRswP6UZa7enNMhRtJN7eqyrya8J7deRTB6qubP8kTGTt+UTlIgivSqThEN9cJu4cWOsdr3X /D9h7aej1jDSerwKIm7UdmrjkOsgUiZhFMphdAgelmfcVdl7CjsqnnYa5eeeVfEMeT3Fv79V qUcg6LfwUGB56gO4OsnMLGCzCbn6kuwbtlCcV10MsTVzvKNFOrs3mm+yZ2msdLJSV2QMNtHW EVXJV2Tlye+XiYtljdyA6GthK+T/Z9qj8nblunMMN9TwCPkIzzKgyKPxIup/MV7CzN2y8nbp BqkFhApTlXt+NflNdqkfqrWcm+XDXbTwvUzFrKVc8QczpVOMuk7kS+MwxtGGEL6QuML/W8hb k1iEeeAQNiNorHshYTJzGb+luQINBFRh3ssBEADQpjP/NdQTZFh11UxsKAOM3KVPSjYxyOEO Gd65/klc3ZBTXJAaC2XmUhYU/kzhyJU7/dd+ywhsLYsWB21mVucAsANra1BkTFXPQFPQwsPP 15QnWQQwFdX7AoMZYceiXqNSWc48DvnXqlUB8TqzB3dSHys9tzfmc+2TDAlM/TpYKWTtY9Fc 2xsx3ZvOzHE1wi6KmdMuK5qc5QBWY16FJtcFA2D5scd24Zy2cO+QS7fDuQHVQpuV+y8unUQC l3VBdOb21WpYrkyUCJU5yRxTP7kbHOIaNyr6S05zArg0TtEfaqCSDOrljxzxSqLtgnD35enE G9/lvQbX8rG0nR1W4ZnhnEx0hAJk2eJ7v9X2Fiq+3rYiEhUsthfBexxoailNxrFIYFr1qBiG zj1HvzoEQZ0Mz/WU156JJBSKAg1IrWzKswIrcv1FoRVhISiEo4nfJslBthZbJjGJ5veYSU5V K4yUNEvcG98+Z4YKFLREXBq6V1AmiFUVbZ1FblK8TGvQaQ3YJlOWEtDA1yrHnujz5wgxtBSM pUsNApQOs2c0MaksfIgkM1McRDwTemup+wmPJ2U8Hvb5A6lI1G+iiUrXPYahdy8XRMxyM1aU xQz53A8Ex+YK/Qn/16k9BZYs/0k3tXb+WBFBcsq732oCo6n4hbfCoG4gYDn7jlEhnm/aQ1Vr eQARAQABiQIlBBgBAgAPBQJUYd7LAhsMBQkJZgGAAAoJEMD02zLS2+sB6kgQAM4V4jIUJo98 rbCU0Yy8YLahwQK5TynS8+zsQ/s9q+aYT8qWzdcjavfRKA3VArGP8qYBXRIQW7QbceSChTOG hhai+5nIJbWhGXVfEUtZ2txahcY2ecfsDEkvCOK7pLKsCq7eYQzMHV8ZPwGWPq+hZa+6msHh R2yUHo6NV2u2HjVJROaM2nUSZT6hOMhzp+zYwl1XEZKqo+QxDtLWJQ66MZIOAngyWN9/ePUJ 0dxG6V+r9MjgHS/OtVlgCKtvAYJCRGcGiSaL+wjhiaZ1/nwBAL0mwN2UaoP+oYjI09J5/Mff tbtQQHMQwRxy31b6N1ZFunnVkR0MeBlT8JtUI31zroRoQ/4u0+wXTYaeTANa0R73Y/m8aIhE sj2ZDD6NISA0Yxnm1rXUyJZosrcS5WjrpgjAjQvkFpm7Sx8Sx+QWpS+DcL8rJntzwL9cPHPA 3tutTbZ9vQrH20TT8Z4nFzTvytFKb5bydF92Fawph2NjFcwzMi/6i37tS1q1X93ky10vq2M4 MaTxIwyjENy6GT5mPh2YlKhWHN5K+8K7rf6QBsvud+SdN3T1AEJojZEYIvxXi0MMpfB4iqlu z+oUbkdDqZonG9QZIME1/BJ3y5oVp5h1r6+vs58a5p/lHjurNYMgbNmWUAcW3trFwXWJispd DhAcLoHO+yCvkKJabrfOZoa2
-
Cc:
Kicad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<96A2A7B6-7477-4220-A029-4D443DC6E3AB@rokeby.ie>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
On 11/02/2019 22:26, Jeff Young wrote:
> Holes seem different (although perhaps it just a different scrolling
> offset), but not fixed:
>
>
Hi Jeff (and others ;-),
I'm working on circle alignment for OpenGL, it also requires some shader
work so it's not that trivial. I'll try to merge all this by Wednesday.
Answering other questions:
- poor cairo graphics on OSX: do you have a Retina display? If so,
what's the native resolution of the screen in your computer and what's
the one reported when creating the cairo context (can you printf
screenSize in CAIRO_GAL::initSurface())? I'm asking because on many OSX
flavors the contents of the window are not rendered at native display
resolution but half of it and then scaled 2 times if the app is not
using Apple's Quartz drawing API? If screenSize <= 2x your native screen
resolution, it's likely the problem causing ugly display. IIRC we had a
similar issue with OpenGL canvas that someone fixed with a special patch
to Mac version of wxWidgets (using some fancy Objective C call).
- concerning text rendering: as JP mentioned already, it's a problem
with our stroke font. It looks bad at low zooms because it lacks
hinting. I doubt it's possible to add it to our stroke font renderer
given the amount of time and effort it requires. Alternative solution is
to use TrueType system fonts, but this surely won't happen earlier than
in V6.
- misaligned arcs and circles are caused by lack of rounding of circle
coordinates/radii in the vertex shader. I'm working on a fix.
Cheers,
Tom
>
>
>> On 11 Feb 2019, at 21:02, Seth Hillbrand <seth@xxxxxxxxxxxxx
>> <mailto:seth@xxxxxxxxxxxxx>> wrote:
>>
>> Am 2019-02-11 15:37, schrieb Jeff Young:
>>> Will do.
>>> BTW, I just finished building your previous patch. Sadly it does not
>>> solve the “holes in graphics” anomalies.
>>> Cheers,
>>> Jeff.
>>
>> Hi Jeff-
>>
>> I can't see the holes in graphics issue, but can you check the
>> attached patch if you have time?
>>
>> BTW, if it's just a easy for you, attaching PNGs for the example
>> images will really help. The TIFF files are not handled by Chrome so
>> I need to save them for Preview.
>>
>> -Seth<0001-GAL-expand-half-pixels-in-super-sampling.patch>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References
-
[patch] GAL pixel alignment
From: Tomasz Wlostowski, 2019-02-10
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Tomasz Wlostowski, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Seth Hillbrand, 2019-02-11
-
Re: [patch] GAL pixel alignment
From: Jeff Young, 2019-02-11