kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Don’t worry; everyone misses at least a few of them the first couple of times.

Cheers,
Jeff.


> On 12 Mar 2019, at 20:18, Brian <lotharyx@xxxxxxxxx> wrote:
> 
> 
>> 
>> As for patches, it's always a good idea to make commits the smallest
>> required size to implement your changes.  Large change sets like the one
>> you posted are difficult to review and comment on.  I did notice a quite
>> a few coding policy[1] errors.  Mostly trailing white space and some K&R
>> curly bracket indentation issues.  If you don't want to be bothered with
>> learning the KiCad coding style, there is a git commit hook (see section
>> 1.3 in the coding policy) that can be called at commit time that will
>> format your code correctly.  You need to have clang-format installed for
>> the commit hook to work.
> 
> I hope the group will chalk those faux-pas-es of mine up to it being my very first submission to this project. :)  I tried to adhere to the coding style policy but I haven’t set up any of the automated tools for that yet.  I will definitely get those into my workflow before my next submission.
> 
> Thanks,
> -Brian
> 
>> Cheers,
>> 
>> Wayne
>> 
>> [1]:
>> http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp