← Back to team overview

kicad-developers team mailing list archive

Zone hatch filling patch

 

Hi JP,

Rather than pollute the bug report[1] with feedback about your zone
hatch filling patch, I moved the conversation to the mailing list.  If
anyone else would like to test and comment on this patch, the patch can
be found in the bug report.

I did some testing and the results look pretty good although it can be a
bit time consuming filling complex zones.  This is to be expected.  One
thing I did notice was that the hatched zone filling appears to leave
really small cutouts in some cases (see attached image).  I know there
is no setting for this but maybe we should use the "Minimum width"
setting to removed excessively small cutouts as well as copper areas.
I'm not sure what users are going to expect here but it's something to
think about.

I also would like you to change the terminology from "grid pattern" to
"hatch" for UI strings, source code naming, and file formatting.  In
other words, the file format token "pattern_thickness" should be
"hatch_thickness", the source code name "m_GridPatternThickness" should
be "m_HatchThickness", and the dialog fill type string type "Grid
Pattern" should be "Hatch". I think "hatch" is more descriptive when
describing this type of zone fill.

Cheers,

Wayne

[1]: https://bugs.launchpad.net/kicad/+bug/1820493

Attachment: zone-hatch-min-width-issue.png
Description: PNG image


Follow ups