| Thread Previous • Date Previous • Date Next • Thread Next |
Hi Carsten, your third patch breaks the Fedora nightly builds. This is the error we get (see [1] for a full build log): FAILED: ? tag-missing : <metadata_license> is not present Validation of files failed error: Bad exit status from /var/tmp/rpm-tmp.3E6TT2 (%check) The reason is that the metadata_license tag is mandatory and must not be omitted. It indicates the license for the appdata.xml file itself. Please take a look at the AppStream specification for details [2]. I vote for reverting commit e5de787 [3]. In my opinion, CC-BY-SA-4.0 is a perfect choice for this kind of file. If the developers prefer a different license, that is fine for me as well. But please add back the tag, so that we can continue distributing nightly builds for Fedora. Best regards, Marcus [1] https://copr-be.cloud.fedoraproject.org/results/@kicad/kicad/fedora-30-x86_64/00875607-kicad/builder-live.log [2] https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license [3] https://git.launchpad.net/kicad/commit/?id=e5de787f881998ed5882132608b6c15d57334a3e Am 27.03.19 um 17:36 schrieb Carsten Schoenert:
Hello Wayne, Am 27.03.19 um 16:34 schrieb Wayne Stambaugh:Hey Carsten, I tried merging your patches and patch 1 does not merge cleanly. Would you please rebase patch 1 so I can get it merged?rebased and re-added. _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
| Thread Previous • Date Previous • Date Next • Thread Next |
