← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Crash Reporter


Hi Wayne-

There are two similar branches there. I was testing tom-crash-reporter-may27 (not tom-crash-reporter). The line numbers in your error don't seem to match up with the ones I see.


On 2019-05-29 18:35, Wayne Stambaugh wrote:
A `git pull` from https://github.com/twlostow/kicad-dev.git says I'm up
to date.

A note to the lead dev team, please do not push your personal
development branches to the main kicad repo.  Thanks.


On 5/29/2019 5:32 PM, Nick Østergaard wrote:
Are you sure you did pull his latest changes?

It worked fine when I built it yesterday.


I just triggered a new build from his branch on github.

A sidenote: Could we delete the branch from the official github on
launchpad? And also the eemodern branch? I think they are confusing,
lets just have feature branches in personal repos.

On Wed, 29 May 2019 at 22:11, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

Hey Tom,

On 5/29/2019 9:56 AM, Tomasz Wlostowski wrote:
On 29/05/2019 06:07, Seth Hillbrand wrote:
On 2019-05-28 12:13, Tomasz Wlostowski wrote:

Done (tom-crash-reporter-may27 on my Github)!


Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" but the
buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version
information.  It says:

KiCad crash report, version 1.0

application: kicad
version:     , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending cebug

Hi Seth,

Just pushed a fix for these. Thanks for testing!


I had no luck building this on windows both 32 and 64 bit builds. I'm
getting two build errors:

The first build error is not related to the debug reporting but this
error (and warning) is:

E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
function 'const wxString formatHex(uint64_t)':
warning: format '%p' expects argument of type 'void*', but argument 4
has type 'size_t' {aka 'unsigned int'} [-Wformat=]
  150 |     snprintf(tmp, 1024, "%p", (size_t) addr);
      |                          ~^   ~~~~~~~~~~~~~
      |                           |   |
      |                           |   size_t {aka unsigned int}
      |                           void*
      |                          %d
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'void DEBUG_REPORT::buildVersionInfo(wxString&)':
error: 'OCC_VERSION_COMPLETE' was not declared in this scope
  277 |     aMsg << indent4 << "opencascade-community-edition: " <<
E:/msys64/home/Wayne/src/kicad-twlostow/common/debug_report.cpp: In
member function 'bool DEBUG_REPORT::AddContext(wxDebugReport::Context)':
error: expected '}' at end of input
  481 |     buildExceptionContextInfo( exceptInfo );
      |                                            ^
note: to match this '{'
  469 | {
      | ^
warning: no return statement in function returning non-void [-Wreturn-type]
  481 |     buildExceptionContextInfo( exceptInfo );
      |                                            ^
make[2]: *** [common/CMakeFiles/common.dir/build.make:1214:
common/CMakeFiles/common.dir/debug_report.cpp.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:264:
common/CMakeFiles/common.dir/all] Error 2
make: *** [Makefile:141: all] Error 2