kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #42201
Re: Footprint keepout zone merge review
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Wed, 9 Oct 2019 10:05:25 -0400
-
Autocrypt:
addr=stambaughw@xxxxxxxxx; prefer-encrypt=mutual; keydata= mQGiBEM0hxQRBAC2fNh3YOVLu1d5GZ0SbrTNldGiGnCJPLqzEnqFX9v6jmf33TMt6EmSLkl6 Wtfkoj0nVwKxcYmJkA8DX0QAokBkwNIzhSsBzQvthBLIk/5LnPVVKrEXOcL4mUyH1doKlkaE slgJozNa6Av+oavcvD02o1zJOloBbaHlNlyRt7fKswCgtIFlVjWggVH/15KfWk+Qo5JVPbME AIUBAQyL2OAx0n60AWec2WHnO9buHuG0ibtICgUMkE+2MRmYyKwYRdyVwGoIUemFuOyHp0AJ InX4T+vy2E7vkwODqjtMLfIoRkokW74Fi4nrvjlhOAw/vdq/twLbAmR9MOfPTpR4y7kQy1O2 /n+RkkRvh26vTzfbQmrH7cBJhk6aA/9Uwvu3E4zNJgHVZeS0HyWtmR1eOPPRbnkPgJTToX5O KMKzTJI/FX6kT7cFoCamitHrW3BJP4Dx+cMMsa47EGxqVTdbVJ4LjogsXTXxb+0Fn1u4zBdx x3Cer6O7+hqWy7zvpzeC6nSREjqDKa5CgHtv/GLm5uFPOmsjAsnHj2tlBrQmV2F5bmUgU3Rh bWJhdWdoIDxzdGFtYmF1Z2h3QGdtYWlsLmNvbT6IeAQTEQIAOBYhBOffs6CbblRzBkv33BtR cWlZ+CReBQJbFBS2AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBtRcWlZ+CReMI8A nRbrLkzp7+c2f0vX7sfg4ICX8LAKAJ9uClo4uJajmZa5zZrL2nKdZlUwIrkCDQRDNIcxEAgA gCru+3/aOC6RCjpvYC72wY+d5SmHphC6yeiV2/mOumyt5MLo/Ps2GznZr11JspqFk5K/Zpvp MMLqqjDZ39+50a2iKRQFJ6NlK+hJWMmj6eJygQrCwYo3Gjc6CqfrqUv+8VSnf/i5sIZmtOVA 4ZjML18MuBvMSsNdVLFJd5HNnYb1iOECpvqdPVh/21LLCEw7MUUGGnHBhCrmk2aJe5hFmcSN g4ldBcXrgMQBwf7aMVoobXBMFDb/IENByXn0llB7Gr2IFMRmNS9/p8s/II1Yl2bTqyX4FSz8 cfn7C9KEz7faZ7wzAcpwHFC/zs3JoAjJ0IEKdNUpIwAlKMzT3CzctwADBQf/cxpG28MKyrqk nNmq/8LQLy+x6FSYXBLjxQz9BiBNYeesDZQ6J5UbL1mjpJzMa5tLZypPYo4bbGyR22hrbyDF K7m6AcVaMIJKl98g4ukMutFfAJyRDaREH5Zl/X1P4u1Z/yaAIy9mKaNbaK1/5djNJ5wCTFen TUgAp9xdc30kGkFDdLJFp5uxDY4P0vaZiZdjUCvDM3Zjv5IzpNOfxVqTUBQNUP/BnnKhkk0p DTD6s3X8S+D0rOtEBQ8K0cwERI/E8EFa8nj0TNw4e2MYGR8wg+SxqJ7z5f0zPY0bO6G9DDFB wYCqzzPWGqdAh9vA5971TAbPERtdFybhkurozp2SfYhJBBgRAgAJBQJDNIcxAhsMAAoJEBtR cWlZ+CResHUAniULLCWiT26ieRTl7N2vS6vBo/DuAJ4m7Ss/gyiW6ybTn1ctDXAUgm2QVQ==
-
In-reply-to:
<d98e5256-59da-e75b-639f-5969898615a0@wanadoo.fr>
-
Openpgp:
preference=signencrypt
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
On 10/9/19 8:36 AM, jp charras wrote:
> Le 09/10/2019 à 00:00, Wayne Stambaugh a écrit :
>> Seth,
>>
>> Please let me finish testing and reviewing the latest changes before you
>> merge it. Sorry about the delay in responding. I have been busy
>> putting the finishing touches on the LIB_PART refactor for the upcoming
>> symbol library file format changes. I should have an answer by the end
>> of the day tomorrow.
>>
>> Cheers,
>>
>> Wayne
>>
>
> Unfortunately, I have crashes if I add a zone keepout to a footprint,
> and trying to refill zones, or move the footprint or undoing the editon
> (not always exactly the same command, but always crashes in one of these
> commands.
>
> To reproduce:
> - Load pic_programmer demo board.
> - edit P3 (Ctrl+E)
> - add a keepout zone on F.Cu+B.Cu and Keep out tracks, vias and zones.
> - save in board.
> - Try to refill zones (and or move P3) and if no crash try undo change.
>
> It crashes every time on my W7-32bits install.
I confirmed this on linux. This will need to be fixed before we can
merge it.
>
> By the way: the zone keepout layer choice is F.Cu and/or B.Cu
> The All copper layer option should be added.
This should be addressed before merging as well.
>
>
>> On 10/8/19 5:13 PM, Seth Hillbrand wrote:
>>> Hi Folks-
>>>
>>> There's a merge request from Ross Schlaikjer[1] that looks like it is
>>> ready for merging. I've looked it over and the current version looks
>>> ready. This is a file format change, so I'd like to get a second set of
>>> eyes before we push.
>>>
>>>
>>> There's some auto-format stuff that I'll clean up in the merge, so this
>>> request is just for functionality and/or implementation comments.
>>>
>>>
>>> Thanks-
>>>
>>> Seth
>>>
>>>
>>> [1] https://code.launchpad.net/~ross-schlaikjer/kicad/+git/kicad/+merge/361410
>>>
>>>
>>>
>>>
>>> Seth Hillbrand
>>>
>>> Chief Technologist
>>>
>>> KiCad Services Corporation
>>>
>>> Twitter Twitter <https://twitter.com/KiProEDA> LinkedIn LinkedIn
>>> <https://www.linkedin.com/company/kicad/about>
>>>
>
References