← Back to team overview

kicad-developers team mailing list archive

Re: Footprint keepout zone merge review

 

On 10/9/19 8:36 AM, jp charras wrote:
> Le 09/10/2019 à 00:00, Wayne Stambaugh a écrit :
>> Seth,
>>
>> Please let me finish testing and reviewing the latest changes before you
>> merge it.  Sorry about the delay in responding.  I have been busy
>> putting the finishing touches on the LIB_PART refactor for the upcoming
>> symbol library file format changes.  I should have an answer by the end
>> of the day tomorrow.
>>
>> Cheers,
>>
>> Wayne
>>
> 
> Unfortunately, I have crashes if I add a zone keepout to a footprint,
> and trying to refill zones, or move the footprint or undoing the editon
> (not always exactly the same command, but always crashes in one of these
> commands.
> 
> To reproduce:
> - Load pic_programmer demo board.
> - edit P3 (Ctrl+E)
> - add a keepout zone on F.Cu+B.Cu and Keep out tracks, vias and zones.
> - save in board.
> - Try to refill zones (and or move P3) and if no crash try undo change.
> 
> It crashes every time on my W7-32bits install.

I confirmed this on linux.  This will need to be fixed before we can
merge it.

> 
> By the way: the zone keepout layer choice is F.Cu and/or B.Cu
> The All copper layer option should be added.

This should be addressed before merging as well.

> 
> 
>> On 10/8/19 5:13 PM, Seth Hillbrand wrote:
>>> Hi Folks-
>>>
>>> There's a merge request from Ross Schlaikjer[1] that looks like it is
>>> ready for merging.  I've looked it over and the current version looks
>>> ready.  This is a file format change, so I'd like to get a second set of
>>> eyes before we push.
>>>
>>>
>>> There's some auto-format stuff that I'll clean up in the merge, so this
>>> request is just for functionality and/or implementation comments.
>>>
>>>
>>> Thanks-
>>>
>>> Seth
>>>
>>>
>>> [1] https://code.launchpad.net/~ross-schlaikjer/kicad/+git/kicad/+merge/361410
>>>
>>>
>>> 	
>>>
>>> Seth Hillbrand
>>>
>>> Chief Technologist
>>>
>>> KiCad Services Corporation
>>>
>>> Twitter Twitter <https://twitter.com/KiProEDA> 	  	LinkedIn LinkedIn
>>> <https://www.linkedin.com/company/kicad/about> 	 
>>>
> 


References