kicad-developers team mailing list archive

[Mikołaj Wielgus <wielgusmikolaj@xxxxxxxxx>]

-  Project manager multiple selection options:
It appears that implementing these enchancements would require significant
changes to the project manager code, since much of the actions is
implemented in TREEPROJECT_ITEM class itself, hence a significant portion
of the actions implementation would have to be placed somewhere else (most
likely to TREE_PROJECT_FRAME class). In addition,
KICAD_MANAGER_CONTROL::Execute would have to be modified to allow passing
several arguments.

Since I'm not very experienced with the codebase yet, and these issues are
minor, and implementing them can potentially cause a lot of issues, I would
like to request pulling the patch as it currently is for the time being.
This will make it easier for me to implement these features later (in the
next patch).

Best regards,
Mikołaj Wielgus


On Mon, Nov 11, 2019 at 12:01 PM Ian McInerney <Ian.S.McInerney@xxxxxxxx>
wrote:

> Thanks for this. Note though that when passing the functions into the
> Connect method in wxWidgets, you should specify the fully qualified name
> (including the class) of the function. When this is not specified, a build
> error happens on my wxWidgets 3.0.4 Linux build. I have pushed a fix for
> this to master.
>
> -Ian
>
> On Mon, Nov 11, 2019 at 8:37 AM jp charras <jp.charras@xxxxxxxxxx> wrote:
>
>> Le 11/11/2019 à 01:04, Mikołaj Wielgus a écrit :
>> > - Pcbnew drill sizes statistics:
>> > I've modified the filter and also made the last two columns expand to
>> > fit the remaining space during grid creation and window resizing.
>> >
>> > As for the column sizes: they are assigned with the wxGrid::AutoSize()
>> > method built-into WxWidgets. Because of that, I'm reluctant to add any
>> > arbitrary values to the column sizes. Also, it's not uncommon for column
>> > widths to be partially concealed in GUI applications (they sometimes
>> > take a lot more space than the table values themselves). The grid is
>> > resizable, so if the user wants to check the label, they will be able to
>> > resize it easily.
>> >
>> > Furthermore, on my operating system, I don't have my column labels
>> > concealed when sorted.
>> >
>> > Because of this, I think it will be better if you tweak the column
>> > widths yourself to make them work as desired in your environment (if you
>> > aren't convinced by my argument). This can be done easily by iterating
>> > over all columns and adding a constant to each one's width right after
>> > the m_gridDrills->AutoSize(); line.
>> >
>> > Please let me know if you have any better idea how to address this.
>> >
>> > Best Regards,
>> > Mikołaj Wielgus
>> >
>>
>> Hi Mikołaj,
>>
>> Thanks for your contribution.
>>
>> I committed your patch (with a minor change to avoid a wxWidgets alert).
>>
>> AFAIK, we always have some issues with column sizing in wxGrid
>> (depending on the platform and wxWidgets version)
>>
>> In this case, this sizing problem is a minor issue.
>>
>> >
>> > On Thu, Nov 7, 2019 at 3:37 PM jp charras <jp.charras@xxxxxxxxxx
>> > <mailto:jp.charras@xxxxxxxxxx>> wrote:
>> >
>> >     Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit :
>> >     > Hello,
>> >     >
>> >     > I have submitted two patches on Launchpad some time ago. I would
>> >     like to
>> >     > ask for feedback.
>> >     >
>> >     > Links:
>> >     > https://bugs.launchpad.net/kicad/+bug/1841144
>> >     > https://bugs.launchpad.net/kicad/+bug/1016464
>> >     >
>> >     > Best Regards,
>> >     > Mikołaj Wielgus
>> >
>> >     Hi Mikołaj,
>> >
>> >     First, thanks for your contribution.
>> >
>> >     I had a look into your patches.
>> >
>> >     I do not seen big problems, but I suggest a few enhancements:
>> >     -  Project manager multiple selection options:
>> >     When deleting a list of files, a confirmation is asked for each
>> file.
>> >     Only one confirmation is enough.
>> >     When deleting a list of files, a instance of the editor is opened
>> for
>> >     each file.
>> >     All editors are able to open more than one file, so I suggest only
>> one
>> >     instance of the editor opening all files.
>> >
>> >     - Pcbnew drill sizes statistics:
>> >     It display pads with no holes. The filter to select pads:
>> >     if( pad->GetAttribute() != PAD_ATTRIB_SMD )
>> >     is incorrect
>> >     (other pads can have no hole).
>> >     the filter must test only the hole size.
>> >     A minor cosmetic issue:
>> >     The columns sizes are too small:
>> >     When sorting a column, the column label is not readable (see X size
>> >     column in attached files).
>> >
>> >     They are minor issues.
>> >     Can you fix them.
>> >
>> >     Thanks.
>> >
>> >
>> >     --
>> >     Jean-Pierre CHARRAS
>> >     _______________________________________________
>> >     Mailing list: https://launchpad.net/~kicad-developers
>> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> >     Unsubscribe : https://launchpad.net/~kicad-developers
>> >     More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>