kicad-developers team mailing list archive

["Steven A. Falco" <stevenfalco@xxxxxxxxx>]

Thanks Ian!

	Steve

On 11/18/19 4:23 PM, Ian McInerney wrote:
> It has been cherry picked into the 5.1 branch, so it will be included in 5.1.6.
> 
> -Ian
> 
> On Mon, Nov 18, 2019 at 9:07 PM Steven A. Falco <stevenfalco@xxxxxxxxx <mailto:stevenfalco@xxxxxxxxx>> wrote:
> 
>     On 11/16/19 1:14 PM, Seth Hillbrand wrote:
>     > On 2019-11-16 08:42, Steven A. Falco wrote:
>     >> It looks like Fedora may be switching from OCE to OCC, so I'm doing a
>     >> trial build with OCC.
>     >>
>     >> How would folks recommend testing the build?  I'm not sure what would
>     >> be necessary.
>     >>
>     >>
>     >> Also, I have a question about CMakeLists.txt.  Around line 91, it says:
>     >>
>     >> option( KICAD_USE_OCC
>     >>     "Build tools and plugins related to OpenCascade Technology
>     >> (overrides KICAD_USE_OCE, default OFF)"
>     >>     OFF )
>     >>
>     >> Note the comment that says KICAD_USE_OCC will override KICAD_USE_OCE.
>     >> Thus, one would think that just setting KICAD_USE_OCC=ON would be
>     >> sufficient to automatically set KICAD_USE_OCE=OFF
>     >>
>     >> Also, the code at line 472 makes it look like setting KICAD_USE_OCC=ON
>     >> would set KICAD_USE_OCE=OFF.  However, in my build, that didn't work,
>     >> and I had to explicitly set KICAD_USE_OCE=OFF.
>     >>
>     >>     Steve
>     >>
>     >
>     > Thanks Steve!  I'm very happy to hear that Fedora is switching.
>     >
>     > I pushed a fix for the issue you've identified.
> 
>     I picked up your fix as a patch against 5.1.5 for Fedora downstream.  I know it is too late to get the fix into official 5.1.5, but I'd like to request that you push the fix for 5.1.6 so I can drop my patch in the future.
> 
>             Steve
> 
>     >
>     > Best-
>     > Seth
>     >
>     > Seth Hillbrand
>     > KiCad Services Corporation
>     > https://www.kipro-pcb.com
>     > +1 530 302 5483 | +1 212 603 9372
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     > More help   : https://help.launchpad.net/ListHelp
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
>