Hi Nick - Yep I've been chatting with Brian about having a look at his
schematic annotation code. Either me or him (depends who gets to it
first!) are going to merge his development branch with the
upstream/master to check it still works, and then take it from
there, either collaborating to get it working if it ticks all the
boxes, or adding any other functionality that has been suggested in
the other threads.
What I'm not clear on yet, Brian, is if the schematic annotation work
you have done is logically separate from the geographic annotation? It
looks like it on the comments from your merge request, but it's just
another thing I need to be sure before I go looking at code seriously.
On Tue, May 12, 2020 at 11:48 PM Nick Østergaard <oe.nick@xxxxxxxxx
<mailto:oe.nick@xxxxxxxxx>> wrote:
I am not sure exactly what kind of annotation stuff you are working
on, but there is another guy working on some geographical annotation.
See https://gitlab.com/kicad/code/kicad/-/merge_requests/108
On Tue, 12 May 2020 at 19:07, Wayne Stambaugh
<stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>> wrote:
>
> Hi James,
>
> By "breaking" changes, I'm assuming you mean changes yet to come
and not
> broken changes which is something all together different. I don't
> foresee any changes that would significantly impact the
annotation code
> if any at all so you are probably safe to work on it. I highly
> recommend that write up a simple proposal either on your GitLab
instance
> or something like Google docs so that the lead dev team can comment.
> This helps to prevent you from wasting your time by implementing
> something that get rejected by the dev team.
>
> I am surprised you think the annotation code looks deceptively
simple.
> I'm still trying to wrap my head around all of the potential
sheet path
> issues and I've written and/or refactored most of that code. I
don't
> think anyone has gotten this right the first time including myself.
>
> All that being said, I think most users would find more advanced
> annotation options useful so I would be in favor of it.
>
> Cheers,
>
> Wayne
>
> On 5/12/20 12:36 PM, James Jackson wrote:
> > Hi all,
> >
> > I'm starting to dig through the code to understand how to
implement a
> > new annotation scheme (all looks deceptively simple in terms
of object
> > manipulation... there will be a crocodile hiding there
somewhere I'm
> > sure!). However, I've noted in a few bug reports and new feature
> > requests that there are likely to be significant changes to
eeschema
> > moving towards v6 (last reference I saw was in relation to
vector and
> > group busses). So, is it wise to start looking at a
significant feature
> > now (if the big changes have happened already), or wait until
those
> > changes are made, or is this not actually an issue? Just
trying to avoid
> > wasting effort and then have to re-duplicate it later!
> >
> > Thanks,
> > James.
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
<mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
<mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
<mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
