← Back to team overview

kicad-lib-committers team mailing list archive

Re: KLC checks for .pretties

 

I already have it set up that way. I just need to tie my stuff in to the
work diggit put in, not a big deal and I'm working on it right now! I
should have a pull request ready by tomorrow hopefully.

On Sun, Apr 3, 2016 at 10:14 PM Carl Poirier <carl.poirier.2@xxxxxxxxx>
wrote:

> What if you used some option like "--diff" to enable your functionality?
> Then we'll still be able to use the script as normal.
>
> On Sun, Apr 3, 2016 at 8:44 PM, Jon Neal <reportingsjr@xxxxxxxxx> wrote:
>
>> Yes, I have my own fork of it (
>> https://github.com/reportingsjr/kicad-library-utils) to do what I needed
>> in jenkins.
>>
>> The reasoning is that there wasn't really a great way to only test
>> components that had been changed in a pull request individually. What I
>> made basically generates a diff of the error output of the master version
>> of the lib versus the pull request version of the lib. If there is a diff
>> then there are new errors, no diff then it is good.
>>
>> The downside of this is if a already has errors and someone updates a
>> part, but doesn't fix those errors then it is reported as a good part.
>>
>> Since diggit redid the error reporting in the checklib.py script I need
>> to finagle my diff stuff in to that. I'll probably end up redoing some of
>> what he did, because while it was a move in the right direction, it is
>> still pretty inflexible error reporting.
>>
>> Jon
>>
>> On Sun, Apr 3, 2016 at 7:20 PM Carl Poirier <carl.poirier.2@xxxxxxxxx>
>> wrote:
>>
>>> Do you mean you branched the scripts as well?
>>>
>>> On Thu, Mar 31, 2016 at 5:15 PM, Jon Neal <reportingsjr@xxxxxxxxx>
>>> wrote:
>>>
>>>> I saw the updates, but they conflict pretty heavily with what I have.
>>>> I'll work on integrating my work in to the main branch tonight.
>>>>
>>>> I have thought about setting up jenkins jobs for all of the
>>>> repositories, but managing it seemed like a nightmare since there are so
>>>> many libraries. It might be possible to script the jenkins jobs, I'll ask
>>>> Nick since he is a bit better at jenkins than I.
>>>>
>>>> Jon
>>>>
>>>> On Mon, Mar 28, 2016 at 9:48 PM Carl Poirier <carl.poirier.2@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> Hi Jon,
>>>>>
>>>>> The Jenkins setup is awesome. I have a few questions about it.
>>>>>
>>>>> 1. For kicad-library, it is using the latest KLC check script, is it?
>>>>> Patrik Bachan has contributed many great fixes to the scripts recently.
>>>>>
>>>>> 2. It would be great to have it setup for each pretty repository. I
>>>>> don't know how Jenkins works, in fact I have just read a tutorial about it.
>>>>> I see there is a CLI for it, do you think it would be feasible to set up
>>>>> the pretty repositories as projects using the fp-lib-table?
>>>>>
>>>>> Regards,
>>>>>
>>>>> Carl
>>>>>
>>>>
>>>
>

References