launchpad-dev team mailing list archive

[Guilherme Salgado <salgado@xxxxxxxxxxxxx>]

On Tue, 2009-09-15 at 14:08 -0300, Guilherme Salgado wrote:
> On Mon, 2009-09-14 at 09:10 -0400, Curtis Hovey wrote:
> > Hi Salgado, Barry.
> > 
> > On Mon, 2009-09-14 at 08:10 -0400, Barry Warsaw wrote:
> > >   * If for some reason you do not want to use the default reversed- 
> > > breadcrumbs in your <title>, implement the `page_title` attribute in  
> > > your view, and set the view class attribute  
> > > `override_title_breadcrumbs` to `True`.  Generally, you will ''not''  
> > > want to do this, so that the default reverse-breadcrumbs are used.   
> > > You should take the time to convert any `pagetitle.py` entries for  
> > > your view to using a `page_title` attribute.
> > >   * If your page template uses `CONTEXTS/fmt:pagetitle`, get rid of  
> > > this.  Use the `base-layout.pt` and it will handle your page title
> > > for  
> > > you.
> > 
> > base-layout still requires a page_title to remove the title from
> > pagetitles.py, even though value is not used. I saw this while working
> > on a leaf page (+packages).
> > 
> > Since the breadcrumbs for many leaf pages are not English, and now show
> > up in the browser title, we have a bigger problem. Should I be writing
> > tests to verify we create insane titles? I think not.
> > 
> > I think I want to define an attribute on the view to provide the last
> > breadcrumb. I looked at Hierarchy and see that the +value is coming from
> > the URL, not an object. Can we mark the view with a interface, or claim
> > it implements IBreadcrumb to provide the text attr?
> 
> The page_title 


The view's page_title (falling back to its entry on pagetitles.py) will
be used as the last breadcrumb's text once my fix for
https://launchpad.net/bugs/423691 lands.

-- 
Guilherme Salgado <salgado@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part