← Back to team overview

launchpad-dev team mailing list archive

Re: Sampledata updates in db-devel?

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Guilherme Salgado wrote:
> On Wed, 2009-11-25 at 15:32 -0500, Curtis Hovey wrote:
>> On Wed, 2009-11-25 at 12:45 -0500, Aaron Bentley wrote:
>>> I just got a bunch of strange test failures because there had been
>>> sampledata changes, and I didn't run "make schema".  They were Soyuz
>>> test failures, so I asked Julian about it, and he got Muharem involved.
>>>  So there was a cost in terms of wasted time.
>>>
>>> I don't like to run make schema more than I have to, because it's slow
>>> and it clears any local changes I've made.  And I only *know* I have to
>>> run it if there have been schema changes.
> 
> I assume these local changes you mention

There were no local changes.  It was a pristine copy of stable.  The
sampledata changes had been landed in devel, and I had an earlier
version of the sampledata in my local db because I don't run make schema
if I don't have to.

> were done in the launchpad_dev
> DB, so it'd be a good idea to update the *dev* sampledata ('make
> newsampledata') and land that on devel.  That way you'll never have to
> do these changes again, and others would benefit from it as well.

I don't understand how that would follow.

> Maybe we should encourage people to update the dev sampledata whenever
> they add/change something in the launchpad_dev DB. That's cheap, doesn't
> cause test failures and is helpful when playing around in
> https://launchpad.dev

> We don't have anything that would prevent changes to
> database/sampledata/* to land on devel, and I don't know of a policy
> that says they should land only on db-devel, so I think it can land on
> devel.

They can right now, and that's disruptive, so I'm proposing a policy
that they land on db-devel instead.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksOmVYACgkQ0F+nu1YWqI1IuACfQKuEbebab5WfZK08hvy7afo5
ackAmgKzu8Y9yMjJrhpe4Z4OSpLmcpfH
=szXy
-----END PGP SIGNATURE-----



Follow ups

References