launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sidnei da Silva wrote:
> Since we are getting into the subject, I would like to work find a
> better home for lp-project-specific plugins. For example, I would like
> to create a few helper commands like:
> 
> bzr link-to-bug 321654 will link the current branch to the specified bug.

I think that should go in bzr core.

> bzr propose-merge 321654 will link the current branch to the specified
> bug and create a merge proposal with two requests for reviews from
> Landscape team members.

I plan to put lp-submit in bzr core in the near future.  We can then
look at adding hooks for specifying reviewers.

Which will leave you needing a plugin to specify landscape policy, but
that seems reasonable to me.

> bzr propose-merge will create a merge proposal, but only if the branch
> is already linked to a bug.

Again, we can do a hook to abort the merge proposal if certain
conditions aren't met.

> We also have some existing ones that could be interesting to other
> people and were heavily borrowed from lp-submit, like 'bzr ls-pep8',
> which finds the files that have been changed from the submit branch
> (if not in a pipeline) or from the previous pipe (if in a pipeline)
> and runs pep8.py on them.

So to me, it sounds like we want to have
1. a landscape plugin that provides landscape policy
2. lp-link-bug in core, lp-submit in core, with good hooks

Launchpad doesn't currently use pep8, so ls-pep8 could just be part of
the landscape plugin, or maybe part of a general bzr-python plugin that
would be tools for python programmers.  It could also go in bzrtools.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAktsOrQACgkQ0F+nu1YWqI0fRgCfdMob3q/qJvpmIGbVB4HChxnY
eoYAniMH4Rg0mjOL5bRO+OcB4NHxIa0y
=NOM8
-----END PGP SIGNATURE-----