← Back to team overview

launchpad-dev team mailing list archive

Re: Code Import Reviews

 

On 07/04/10 10:03, Jelmer Vernooij wrote:
On Tue, 2010-04-06 at 14:03 +0100, James Westby wrote:
I'd like to discuss reviews of new code imports.

Currently SVN and CVS code imports require review before working. What
are the reasons for this?
I'm not sure about the reasons for requiring review for the CVS imports,
but at least for the Subversion servers it's to prevent people from
accidentally registering an import of the repository root, causing a lot
of disk usage and processing time on Launchpad's side. Copies are cheap
in Subversion (E.g. creating a new tag) but, unless they're branch
copies, they're expensive in Bazaar.

And maybe it's because of a confusing UI, but people get this wrong a lot, and maybe 30-50% of svn imports need to be corrected before approval.

The heuristics code in bzr-svn could be used to automatically approve
Subversion branches that appear legitimate (I've only seen a few
situations where it didn't gets the repository layout right).

Ah yes, I must get you to tell me or someone else how to do that!

Cheers,
mwh



Follow ups

References