launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/09/2010 11:25 AM, Graham Binns wrote:
> So, question #1: What should the From: address be for bug
> notifications? There are two possible options, as I see it:
> 
>  1. Always use $bugno@xxxxxxxxxxxxxxxxxx
>  2. Use the Person's preferred email address where possible (i.e
> assuming they have one and that they haven't marked their email
> addresses as private), otherwise use $bugno@xxxxxxxxxxxxxxxxxx.

I prefer this.  When we receive emails from reviews, we basically just
forward them with some tweaks, retaining the same message-id.  If we
don't at least try to retain the from address, that gets harder to justify.

> I think it makes sense to standardise on this across Launchpad, so if
> there's something that already exists to handle all this please point
> it out to me so I can see if it's reusable.

We use lp.services.mail.basemailer.BaseMailer to send notifications.
I'd love to see that reused and adapted to support your needs.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwPurEACgkQ0F+nu1YWqI38zQCggm/4vfTGiLjjs+qcrgAH+ive
IFMAnAt8BYcAR17j2QSDVbzeXnOIkxzx
=ocQC
-----END PGP SIGNATURE-----