launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-01-06 02:41 PM, Graham Binns wrote:
>  1. I ran bzr lp-land rather than utilities/ec2 land.
>  2. I realised my error when it asked me for a commit message and quit
> the editor.

I use a graphical editor, so I can ^C in the terminal when I need to abort.

>  3. I was then prompted ("The commit message has not been changed...Do
> you still want to use it, etc."). Instead of saying "No" to this, I
> CTRL-C'd.

Actually, I wouldn't be surprised if you put "No".  lifeless changed
edit_commit_message to prompt you if the message is unchanged*, and
return nothing if the answer is No.  But he didn't update lp-land to
expect that edit_commit_message might return nothing and treat it as
user cancellation.

>  4. I then ran utilities/ec2 land and wasn't prompted for a commit
> message (though I didn't think this odd; I should have).
> 
> So, what appears to have happened - if my memory is right anyway - is
> that lp-land hasn't treated my KeyboardInterrupt in the same way as it
> would have tret me saying "No" to the prompt.

It's true that KeyboardInterrupt and "No" at the prompt are not the
same, but KeyboardInterrupt is the one that will actually prevent the
landing from proceeding.

> (Note, I haven't yet
> looked at the code to confirm this; it's just my recollection of
> things). I'll check shortly.
> 

Aaron

* another anti-feature, IMO, since the messages usually don't need to be
edited.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mIKIACgkQ0F+nu1YWqI3pQACfZuyOItWH+8IfwLdKTcJfCaHv
v6cAnjwRFnDT/OUZNDKAXkZOlzk0H9fD
=Nutj
-----END PGP SIGNATURE-----