launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-01-06 03:10 PM, Robert Collins wrote:
> I think the bug is purely in lp-land, 'no' is != ctrl-C. exception
> handling is well understood in python, the code probably wasn't
> written to handle ctrl-c - or *other* exceptions (and thus is likely
> an easy fix).

FWICT, the code is unconditionally setting the commit message on the
merge proposal before giving the user a chance to edit it.  So the merge
proposal not only gets gunk prepended to it, but it's the *wrong* gunk,
because it doesn't contain the user's edits.

Aaron

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mI6EACgkQ0F+nu1YWqI0mewCfbmyCu9H4/oBryYLRprRofSqo
lCEAn0iM3dK9uEYzoCYZqT6DHVYdp7iF
=Y6i7
-----END PGP SIGNATURE-----