launchpad-dev team mailing list archive

[John Arbash Meinel <john@xxxxxxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/27/2011 9:38 PM, Robert Collins wrote:
> On Fri, Jan 28, 2011 at 1:13 PM, Max Kanat-Alexander
> <mkanat@xxxxxxxxxxxx> wrote:
>>>  - To enable this, we're going to put the work on trunk which isn't
>>> yet deployable in Launchpad into a new 'future' branch, and reset
>>> trunk back to 1.18
>>
>>        I think the fact that jam has done nearly all the work required to
>> stabilize trunk in a single day proves that this is unnecessary.
>>
>>        It seems likely that creating that "future" branch means it will never
>> be looked at, and instead of adopting the sweeping architectural changes
>> which fix most of loggerhead's problems, you will waste time re-fixing
>> all of that piecemeal with a poorer architecture.
>>
>>        I do understand the value of your plan, though. Perhaps the best
>> solution would be to give jam some time to see what he can do, and then
>> make the decision after that.
> 
> John has some time from Martin to do just that; if/when he is
> successful, his work can be merged into the consolidated trunk,
> released & deployed - nothing is meant to prevent that; merely not to
> make doing that a high stress zomg urgency thing required to unblock
> bugfixes and maintenance.
> 
> -Rob

Having just gone through the two branches, I'll note that the Launchpad
PQM version of loggerhead is *not* 100% appropriate as a Loggerhead trunk.

It has a small handful of very site-specific customization for
Launchpad. Post notably (I think this is adding a link to
https://help.launchpad.net to every page with a menu):

=== modified file 'loggerhead/templates/menu.pt'
- --- loggerhead/templates/menu.pt	2008-08-13 17:33:41 +0000
+++ loggerhead/templates/menu.pt	2008-08-14 22:45:52 +0000
@@ -13,6 +13,8 @@
         <li><a tal:attributes="href python:url('/files', clear=1);
                                title string:Files;
                                id string:on">Files</a></li>
+        <li><a tal:attributes="href
string:https://help.launchpad.net/Loggerhead;
+                               title string:Help">Help</a></li>
         </tal:fileview-active>
       </ul>
 </tal:menu>


If you specifically consider PQM to be more stable than the existing
trunk, and want to manage it from there, that's fine. But I think we
need to be aware of some things like this.

I also don't know what this means for users that *today* are running
loggerhead trunk. (Peng on IRC comes to mind.) I noticed you didn't get
many responses via email, perhaps because the original message was long.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1C5KEACgkQJdeBCYSNAANM0ACgsGYHjrjTGuaK7L7xYC8utzRX
yuYAoJi5bEEFPxOOSqVAs7fJylfymJxU
=mdjk
-----END PGP SIGNATURE-----