launchpad-dev team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

On Tue, Feb 22, 2011 at 10:45 AM, Stuart Bishop
<stuart.bishop@xxxxxxxxxxxxx> wrote:
> On Mon, Feb 21, 2011 at 9:38 PM, Jonathan Lange
>>> The mockdb is an ongoing project I hope to revisit soon, which should
>>> be simpler now we have switched to Storm (as indicated by the
>>> comments). Tests will replay from a recording instead of querying the
>>> real db for hopefully massive speed improvements.
>>>
>>
>> Sounds like a good idea. Should it be in the tree before it's actually usable?
>
> We generally like to merge things in pieces than maintaining multi-k
> line diffs in feature branches. The completed feature was a gnats arse
> from landing but got stuck in review so long the storm-a-geddon
> derailed it - I'm glad as much of it is in tree as it is for when the
> pieces get picked up (soon I hope!)
>

The reason we like merging things is we don't like having work lying
around that isn't yet helping someone (especially if that
work-in-progress has to be maintained). All unmerged branches are like
that, but so is unused code.

I very much hope it gets picked up soon.

>>> This is also where the testsuite's database test fixture lives, which
>>> is strangely enough rather necessary :)
>>
>> I can bring myself to believe that. Hmm, actually. Are you talking
>> about pgsql or mockdb here?
>
> I mean we need a database fixture. It doesn't have to live anywhere in
> particular.
>

Where does it live now? (i.e. What is the "this" in "This is also
where the testsuite's database..."?)

>>> I think the module is deprecated in favor of putting things in a
>>> better location...
>>>
>>
>> Ahh I see. Not that "you ought to use something else", but rather "you
>> should not put new stuff in here"?
>
> Yes, along with everything in canonical.*.
>

Cool. Thanks for clarifying.

jml