← Back to team overview

launchpad-dev team mailing list archive

Re: story tests - any objects to a single mass conversion to regular pagetests

 

Hi Robert,

I'm sorry to disappoint you, but that won't work. Most of our story
tests are now isolated. Only stories starting by a number are actually
part of a unisolated sequence. A naive grep finds 68 such files that are
part of a sequence. If it's only those sequence you wanted to collapse,
and it will require a shell script a little bit more clever than your
example one.

Cheers

On 11-07-06 01:29 AM, Robert Collins wrote:
> Our story tests are awkward: they *explicitly* want to avoid test
> isolation between each component, but this breaks the test runner
> model. The breakage of the model leads to tests that are parallel
> unsafe, poor interaction with testr and probably other things I can't
> quickly point at.
> 
> I was looking at various workarounds but the easiest one is for us just to do
> cat story/* > story.txt; rm -f story
> for each story.
> 
> We only have a dozen or so left that this would matter to.
> 
> Unless someone has a compelling reason not to (and 'we should migrate
> them to unittests' is interesting but orthogonal :)) - I'll do this
> and land it on friday.
> 
> -Rob
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~launchpad-dev
> Post to     : launchpad-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~launchpad-dev
> More help   : https://help.launchpad.net/ListHelp


-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxx

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References