launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Review: Approve

Looks good. In addition to the alignment of the closing braces JC brought up, I've got a couple other suggestions.

As we discussed in IRC, widgets have a CSS_PREFIX value you can set to manually override the generated CSS prefix based on NAME. This might let you continue the idea of extending the Autocomplete widget.

http://yuilibrary.com/yui/docs/api/files/widget_js_Widget.js.html#l95

Small naming question/suggestion. Now that we're starting to properly build and namespace our JS, I'm trying to see if I can start to simplify naming. So could the module just be Y.lp.bugs.tags_entry [sans bug_]?

#197 is the autocomplete declared var?

#294/300/306/307 please surround attribute selectors in quotes: id="field.tag"


-- 
https://code.launchpad.net/~sinzui/launchpad/bug-tag-completions/+merge/112580
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.