← Back to team overview

libravatar-fans team mailing list archive

Re: New design

 

As stated in the MR, it's already fixed in the branch and already deployed
to STG!

Oliver

On Wed, Jun 5, 2019 at 12:13 PM Niklas Poslovski <ni.pos@xxxxxxxxxx> wrote:

> You're right,I didn't see it in the source code,sorry.
> We don't have a manifest.json and I think we don't need one so I
> removed the link to it from the header.
> It's fixed here:
> https://git.linux-kernel.at/oliver/ivatar/merge_requests/143
>
> Am Mi, 5. Jun, 2019 um 9:59 A. M. schrieb clime <clime7@xxxxxxxxx>:
> > On Wed, 5 Jun 2019 at 11:58, clime <clime7@xxxxxxxxx> wrote:
> >>
> >>  On Wed, 5 Jun 2019 at 11:55, Niklas Poslovski <ni.pos@xxxxxxxxxx>
> >> wrote:
> >>  >
> >>  > There is no manifest.json file (navigating to it manually just
> >> shows
> >>  > the homepage) and it doesn't show this error for me in Firefox
> >> with
> >>  > only uBlock Origin.
> >>  > Often buggy extensions cause errors like that in the Javascript
> >> console.
> >>  > Please disable as many plugins as possible and try again then.
> >>  > Additionally I got the suggestion that we should add a screenshot
> >> how
> >>  > Libravatar can be used and I think that's good idea.
> >>  > What do you think about adding a small screenshot in the head of
> >> the
> >>  > homepage at the right side?
> >>  > There's so much unused space.
> >>
> >>  Hello Nikla!
> >
> > Niklas! sry :)
> >
> >>
> >>  The error is valid. It's cased by the following link tag in source
> >> code:
> >>  <link rel="manifest" href="/manifest.json">
> >>
> >>  I think we could rather add a link to a quick tutorial instead of a
> >> screenshot.
> >>  I don't know how much informatioin could be extracted from a single
> >> screenshot.
> >>
> >>  clime
> >>  >
> >>  > Am Mi, 5. Jun, 2019 um 9:47 A. M. schrieb clime
> >> <clime7@xxxxxxxxx>:
> >>  > > On Wed, 5 Jun 2019 at 11:41, Oliver Falk
> >> <oliver@xxxxxxxxxxxxxxx>
> >>  > > wrote:
> >>  > >>
> >>  > >>  Hi!
> >>  > >>  Thanks Niklas for updating the redesign branch. It's merged
> >> now and
> >>  > >> deployed.
> >>  > >>  Maybe/Hopefully, the problems Michal sees are gone now as
> >> well!?
> >>  > >> @clime ?
> >>  > >
> >>  > > Yes, fonts are there now. Thanks! There is still some problem
> >> with
> >>  > > /manifest.json file
> >>  > > (see the screenshot, please).
> >>  > >
> >>  > >>
> >>  > >>  Oliver
> >>  > >>
> >>  > >>  On Wed, Jun 5, 2019 at 12:05 AM Niklas Poslovski
> >>  > >> <ni.pos@xxxxxxxxxx> wrote:
> >>  > >>>
> >>  > >>>  I can confirm that there are really some errors.
> >>  > >>>  The font files for lato bold are missing.
> >>  > >>>  That's fixed in the pull request I submitted today but I
> >> think it
> >>  > >>> isn't on the staging server yet.
> >>  > >>>
> >>  > >>>  > On Fri, 31 May 2019 at 13:58, Oliver Falk
> >>  > >>> <oliver@xxxxxxxxxxxxxxx> wrote:
> >>  > >>>  >
> >>  > >>>  >> Hey clime!
> >>  > >>>  >> Can you do a forced reload? I don't see that issue and it
> >> loads
> >>  > >>> different fonts for me.
> >>  > >>>  >
> >>  > >>>  > Hey!
> >>  > >>>  >
> >>  > >>>  > did a forced reload, still getting the errors. You can
> >> also see
> >>  > >>> them
> >>  > >>>  > in js console.
> >>  > >>>  >
> >>  > >>>  >> KR,
> >>  > >>>  >> Oliver
> >>  > >>>  >>
> >>  > >>>  >> On Thu, May 30, 2019 at 10:44 AM clime <clime7@xxxxxxxxx>
> >> wrote:
> >>  > >>>  >>
> >>  > >>>  >>> Hello Lukas,
> >>  > >>>  >>>
> >>  > >>>  >>> thank you for the optimized version! Again, I really
> >> like the
> >>  > >>> layout
> >>  > >>>  >>> but I actually prefer colors that can be seen at
> >> production
> >>  > >>>  >>> (libravatar.org).
> >>  > >>>  >>>
> >>  > >>>  >>> And also fonts seems more fancy at the production at the
> >>  > >>> moment but
> >>  > >>>  >>> maybe it is because I am mssing something cause I am
> >> getting
> >>  > >>> some 404s
> >>  > >>>  >>> for fonts on libravatar-stg.fedorainfracloud.org (see the
> >>  > >>> attached screenshot).
> >>  > >>>  >>>
> >>  > >>>  >>> Anyway, these are not blockers or anything. I think just
> >> for
> >>  > >>> the home
> >>  > >>>  >>> layout improvements, we should employ it.
> >>  > >>>  >>>
> >>  > >>>  >>> clime
> >>  > >>>  >>>
> >>  > >>>  >>> On Tue, 28 May 2019 at 10:41, Lukas Schönsgibl
> >>  > >>> <lschoensgibl@xxxxxxxxx> wrote:
> >>  > >>>  >>>>
> >>  > >>>  >>>> Thank you for your kind feedback!
> >>  > >>>  >>>>
> >>  > >>>  >>>> Deployed a newer version with optimizations based on
> >> your
> >>  > >>> input:
> >>  > >>>  >>>>
> >>  > >>>  >>>> Fonts are now installed at the server.
> >>  > >>>  >>>> I've tried a newer - kind of little darker - design to
> >> get it
> >>  > >>> less 'shiny'.
> >>  > >>>  >>>>
> >>  > >>>  >>>> If you find any design-bugs, please let me know!
> >>  > >>>  >>>>
> >>  > >>>  >>>>
> >>  > >>>  >>>> Am Mo., 27. Mai 2019 um 21:12 Uhr schrieb clime
> >>  > >>> <clime7@xxxxxxxxx>:
> >>  > >>>  >>>>>
> >>  > >>>  >>>>> Mobile version looks great. Web too. Colors could be a
> >> bit
> >>  > >>> less shiny.
> >>  > >>>  >>>>>
> >>  > >>>  >>>>> Dne po 27. 5. 2019 19:11 uživatel Niklas Poslovski
> >>  > >>> <ni.pos@xxxxxxxxxx> napsal:
> >>  > >>>  >>>>>>
> >>  > >>>  >>>>>> The design looks really good,except some small
> >> bugs,for
> >>  > >>> example when opening the account dropdown in the navbar.
> >>  > >>>  >>>>>> Additionally some elements with Bootstraps default
> >> design
> >>  > >>> have to be optimized to fit better into the rest of the page
> >> but
> >>  > >>> that shouldn't be that complicated.
> >>  > >>>  >>>>>> In general I think it looks much better than mine.
> >>  > >>>  >>>>>> It's somehow even more modern and optimized for this
> >> sort
> >>  > >>> of service.
> >>  > >>>  >>>>>> What I'm not happy about is that my uBlock Origin
> >> blocks
> >>  > >>> Google shit two times at a single page.
> >>  > >>>  >>>>>> We should either download and selfhost those fonts or
> >> just
> >>  > >>> use default system fonts.
> >>  > >>>  >>>>>> Privacy is always priority number one for me ;)
> >>  > >>>  >>>>>>
> >>  > >>>  >>>>>> > Hi all!
> >>  > >>>  >>>>>> >
> >>  > >>>  >>>>>> > A friend of mine provided another design for
> >> Libravatar
> >>  > >>> and I deployed it to staging for the moment:
> >>  > >>>  >>>>>> >
> >>  > >>>  >>>>>> > https://libravatar-stg.fedorainfracloud.org/
> >>  > >>>  >>>>>> >
> >>  > >>>  >>>>>> > What do you think? Shall we go with this? Opinions?
> >>  > >>>  >>>>>> >
> >>  > >>>  >>>>>> > I'll add him CC:, so, if you reply, please use
> >> reply to
> >>  > >>> all! :-)
> >>  > >>>  >>>>>> >
> >>  > >>>  >>>>>> > Cheers,
> >>  > >>>  >>>>>> > Oliver
> >>  > >>>  >>>>>>
> >>  > >>>  >>>>>> _______________________________________________
> >>  > >>>  >>>>>> Mailing list: https://launchpad.net/~libravatar-fans
> >>  > >>>  >>>>>> Post to : libravatar-fans@xxxxxxxxxxxxxxxxxxx
> >>  > >>>  >>>>>> Unsubscribe : https://launchpad.net/~libravatar-fans
> >>  > >>>  >>>>>> More help : https://help.launchpad.net/ListHelp
> >>  >
>
>
>

References