← Back to team overview

maria-developers team mailing list archive

Re: redundant compilation of targets in mariadb 10.0

 

Hi, Rohit!

On Mar 17, Rohit Kalhans wrote:
> hello Sergei
> 
> the modification was made in some replication specific files
> rpl_gtid.h & rpl_gtid.cc
> 
> *rohit@ubuntu:/work/mariadb/mariadb/mariadb10$ bzr st *
> *modified:*
> *  sql/rpl_gtid.cc*
> *  sql/rpl_gtid.h*
> *unknown:*
> *  mysql-test/suite/rpl/t/rpl_x.test*
> 
> There are a lot of targets being rebuild.
> 1. stroage*
>           perfschema
>           aria
>           xtradb
> 2. handlers
> 3. sql core
>      item*

This is correct. It happens because sql_class.h includes rpl_gtid.h.
And almost every storage engine, items, everything needs THD that is
declared in sql_class.h

You can easily verify that yourself, put #error into rpl_gtid.h and
you'll see that lots of files will not compile - which means all these
files include rpl_gtid.h and they have to be rebuilt when rpl_gtid.h
changes.

Regards,
Sergei


References