maria-developers team mailing list archive
-
maria-developers team
-
Mailing list archive
-
Message #08765
Re: Please review: MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode through a default value
Hi, Alexander!
On Jun 25, Alexander Barkov wrote:
> >
> > it's trivial to put it in a separate commit with "git citool"
> > if it'd be difficult to extract it - then yes, but mention is
> > explicitly in the commit comment ("also fixes the case....").
>
> I am adding tests for both bugs:
>
> MDEV-7824 [Bug #68041] Zero date can be inserted in strict no-zero mode
> through a default value
>
> MDEV-8373 Zero date can be inserted in strict no-zero mode through
> CREATE TABLE AS SELECT timestamp_field
>
> into a new shared file mysql-test/include/type_temporal_zero_default.inc
>
> Does git citool support partial commit in such case?
> I.e. if I want to add a part of a new file in the first commit, and then
> add the rest of the new file in the second commit?
Yes.
ok to push
Regards,
Sergei
References