← Back to team overview

maria-discuss team mailing list archive

Re: MariaDbConnector 1.x -> 2.6, problem updating/inserting Torque objects

 

> Correction on "internal" classes is not a solution
agree

> could you create a JIRA issue
https://jira.mariadb.org/browse/CONJ-809 pls feel free to clarify the issue

Von: Diego Dupin <diego.dupin@xxxxxxxxxxx>
Gesendet: Dienstag, 21. Juli 2020 19:08
An: Clemens Wyss - MySign AG <clemens.wyss@xxxxxxxxx>
Cc: Eric Herman <eric.herman@xxxxxxxxx>; maria-discuss@xxxxxxxxxxxxxxxxxxx
Betreff: Re: [Maria-discuss] MariaDbConnector 1.x -> 2.6, problem updating/inserting Torque objects

Hi, could you create a JIRA issue for that on https://jira.mariadb.org/browse/CONJ ?

JDBC state that https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/ResultSetMetaData.html#isReadOnly(int) Indicates whether the designated column is definitely not writable.
Driver indicate that resultset not an updatable resultset. Feel more like a bug
Correction on "internal" classes is not a solution.

On Tue, Jul 21, 2020 at 3:52 PM Clemens Wyss - MySign AG <clemens.wyss@xxxxxxxxx<mailto:clemens.wyss@xxxxxxxxx>> wrote:
Hi Eric,
first of all: thx for the ultra fast reply

> configuration variable
we've got the options "at hand". Hence we could add "enforceUpdatableResultSet" (per default false) to Options and then
> new MariaDbResultSetMetaData(columnsInformation, options, forceAlias, options.enforceUpdatableResultSet )

Still feels like a very "localized solution"

-----Ursprüngliche Nachricht-----
Von: Eric Herman <eric.herman@xxxxxxxxx<mailto:eric.herman@xxxxxxxxx>>
Gesendet: Dienstag, 21. Juli 2020 07:43
An: Clemens Wyss - MySign AG <clemens.wyss@xxxxxxxxx<mailto:clemens.wyss@xxxxxxxxx>>; maria-discuss@xxxxxxxxxxxxxxxxxxx<mailto:maria-discuss@xxxxxxxxxxxxxxxxxxx>
Betreff: Re: [Maria-discuss] MariaDbConnector 1.x -> 2.6, problem updating/inserting Torque objects

On 7/21/20 6:39 AM, Clemens Wyss - MySign AG wrote:

> I could patch org.mariadb.jdbc.internal.com<http://org.mariadb.jdbc.internal.com>.read.resultset.
> SelectResultSet# getMetaData to  return
>> new MariaDbResultSetMetaData(columnsInformation, options, forceAlias,
>> false )
> instead of
>> new MariaDbResultSetMetaData(columnsInformation, options, forceAlias,
>> true )
> but that doesn't really feel "right" 😉

I agree, that doesn't feel "right" ... yet, a patch could be a reasonable short-term work-around, until a better solution becomes apparent.

I would recommend patching such that the boolean value is pulled from a configuration variable if present, otherwise defaults to the current value. In this way, your patch may even be something which you could contribute, as it may turn out to be useful for others.

--
Eric Herman
mobile:+31 620719662 skype:eric_herman jabber:eric.herman@xxxxxxxxx<mailto:jabber%3Aeric.herman@xxxxxxxxx>
_______________________________________________
Mailing list: https://launchpad.net/~maria-discuss
Post to     : maria-discuss@xxxxxxxxxxxxxxxxxxx<mailto:maria-discuss@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~maria-discuss
More help   : https://help.launchpad.net/ListHelp


--
Diego Dupin,
Connector team

References