← Back to team overview

multi-touch-dev team mailing list archive

Re: Package review for xserver-xorg-input-evdev

 

On 08/20/2010 05:18 PM, Chase Douglas wrote:

> Hi all,
> 
> Normally we do all our packaging and reviewing in lp and bzr. However,
> the xserver-xorg-input-evdev package is maintained in git at
> git.debian.org. I have pushed a new version of evdev with gesture
> changes to git://kernel.ubuntu.com/cndougla/xserver-xorg-input-evdev.git
> branch ubuntu.
> 
> I would like to do a packaging review just like we do in lp, so I'd like
> to do it over this list if that's alright with everyone. If a better
> mechanism comes about, feel free to propose it :).


How about sending the actual patches ala lkml? Definitely easier to review :-)

Ok, here comes comments.

configure.ac:

We actually depend on xserver being built with gesture support here... if
somebody on non-ubuntu takes this evdev, compiles it with --enable-grail, what
will happen?

GrailGesture:

Still have a problem here with mixed device/screen coordinates based on pad/screen.

EvdevProcessEvent:

abs_mt_x_min etc aren't really used anymore.

101-gestures.patch:

still contains references to gevdev

Cheers,
Henrik



Follow ups

References