← Back to team overview

openerp-community team mailing list archive

Re: Merge delay time for proposals on community projects

 

Dear all,


I give my opinion here as it seems it is not the first time we have an
issued with this (I made the mistake once my-self, so even being voluntary
is not enough).

@Nhomar : As suggested by Stefan, if you need to be that quick, make a
branch for your customer, it is not a reason to merge in community repo.
for that.

A clear rule here matters. I'm personally in favor of:

 * 5 calendar days to wait for
 * 3 Reviews to bypass this delay otherwise 2 would be enough

We'll have soon a structure together to write down all those rules. We'll
communicate on this during the community days.

Looking forward to see you,

Regards,

Joël



On Thu, Jun 13, 2013 at 2:20 PM, Nicolas Bessi <nicolas.bessi@xxxxxxxxxxxxxx
> wrote:

> Hi,
>
> My Apologies I didn't understand the 5*calendar* days notion. My English
> tricked me.
>
> Regards
>
> Nicolas
>
> Le Thu Jun 13 14:11:06 2013, Stefan Rijnhart a écrit :
> > On 06/13/2013 01:56 PM, Nicolas Bessi wrote:
> >> Hello,
> >>
> >> So should we wait 3 or 5 days before fixing a community rule :P ?
> >>
> >> Actually we have:
> >>
> >> 3 in favor of 3 reviewers
> >> 1 in favor of 2 reviewers
> >>
> >> 2 in favor of 3 days
> >> 1 in favor of five days
> >>
> >
> > Hi,
> >
> > For the record, I suggested the number of three reviews to override the
> minimum merge delay in case of emergencies. I personally think two
> approvals should be fine after the minimal merge delay time.
> >
> > Note that I suggested 5 *calendar* days for the delay, which corresponds
> to the 3 working days that Nicolas suggested relatively often but leaves
> room for flexibility in working days.
> >
> > Cheers,
> > Stefan.
> >
> --
> Nicolas Bessi
> Senior ERP consultant
> Business Solution technical manager
>
> Camptocamp SA
> PSE A
> CH-1015 Lausanne
> http://openerp.camptocamp.com
>
> Phone: +41 21 619 10 26
> Office: +41 21 619 10 10
> Fax : +41 21 619 10 00
> --
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>



-- 


*camptocamp*
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

*Joël Grand-Guillaume*
Division Manager
Business Solutions

+41 21 619 10 28
www.camptocamp.com

Follow ups

References