← Back to team overview

openerp-community team mailing list archive

Re: Merge delay time for proposals on community projects

 

Agree with that.

A remark on the rule :

 * 3 Reviews to bypass this delay otherwise 2 would be enough

It implies that 2 approvals are required after 5 calendar days, although I agree with the principle, I'm not sure we actually reach 2 approvals on all the MPs.

I think it shouldn't be a blocker if a MP lasts weeks and nobody disapprove it, albeit it should at least be approved by 1 person in any case. In an ideal world I would prefer to have many reviewers for each MP though.

Guewen

On 06/13/2013 02:30 PM, Joël Grand-Guillaume wrote:
Dear all,


I give my opinion here as it seems it is not the first time we have an
issued with this (I made the mistake once my-self, so even being
voluntary is not enough).

@Nhomar : As suggested by Stefan, if you need to be that quick, make a
branch for your customer, it is not a reason to merge in community repo.
for that.

A clear rule here matters. I'm personally in favor of:

  * 5 calendar days to wait for
  * 3 Reviews to bypass this delay otherwise 2 would be enough

We'll have soon a structure together to write down all those rules.
We'll communicate on this during the community days.

Looking forward to see you,

Regards,

Joël





References