← Back to team overview

openerp-community team mailing list archive

Re: Suggestion for OCA conventions



I agree with Sandy's suggestion.

About the sale_order and sale_order_line files, I would prefer two files.
It avoid to have an exception on the basic rule "one model, one file", that
is maybe not perfect, but like all rules...

Once that is decided, we can imagine a script to check that rules, (such as
checking pep8) and report result in Travis.


*Sylvain LE GAL*

* Service informatiqueGroupement Régional Alimentaire de Proximité*
3 Grande rue des feuillants 69001 Lyon
*Bureau : *(+33)
*Astreinte :* (+33)
*Site Web** : *www.grap.coop
*Twitter : *@legalsylvain* <https://twitter.com/legalsylvain>*

2014-10-19 15:45 GMT+02:00 Daniel Reis <dgreis@xxxxxxx>:

> On 18-10-2014 09:12, Pedro Manuel Baeza Romero wrote:
>> Hi, I'm with Sandy that splitting each model in a class is a win
>> strategy, but with a middle term: if you have models that comes from a
>> one2many field, I prefer having these classes also in the same file as the
>> main class. For example, I would put sale.order and sale.order.line in the
>> same file, /sale_order.py/, but res.partner in another file called /
>> res_partner.py/.
> +1 for Pedro. Most of the time "lines" are just a "part" of parent model
> and it can make sense to keep them together.
> DR
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp

Follow ups