openerp-community team mailing list archive

[Yannick Vaucher <yannick.vaucher@xxxxxxxxxxxxxx>]

This is a good idea to follow some standard.

However, SPDX meta tag "SPDX-License-Identifier" is not yet widely used.

It seems that it was firstly used by U-boot project
https://github.com/linux-sunxi/u-boot-sunxi/commit/1a4596601fd395f3afb8f82f3f840c5e00bdd57a

AFAICT it is still under draft proposal:
http://wiki.spdx.org/view/Technical_Team/SPDX_Meta_Tags
http://www.fossology.org/issues/6051

So the idea is good to try to comply with SPDX, and if we agree with this
early adoption, then here would be the new header:

# -*- coding: utf-8 -*-# Copyright 2015 <company or author>
# SPDX-License-Identifier: AGPL-3
# For license see __openerp__.py or http://spdx.org/licenses/AGPL-3.0

With author and contributors in __openerp__.py

And I'm not sure about what to put or not in __openerp__.py and weither or
not we should keep the pointer to __openerp__.py
Nevertheless, as our modules can be downloaded from apps.odoo.com, and thus
it wouldn't include root LICENSE file, we do need to keep __openerp__.py as
it or to include LICENSE file at module level.


Cheers,


Yannick Vaucher
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 30
Office: +41 21 619 10 10
http://www.camptocamp.com/

On Wed, Jan 7, 2015 at 7:10 PM, Jerry Van Baren <gvb.openerp@xxxxxxxxx>
wrote:

>  On 01/05/2015 06:09 AM, Yannick Vaucher wrote:
>
>  Most developers dislike redundancy, thus, all are tempted to reduce the
> size of source code by reducing or completly removing redundant license
> from source files. [1]
>
> [snip]
>
>  To be said I'm completely against removing completely the header I think
> a minimal copyright must be present in each source file to be read by the
> one who opens the file.
>
> Suggestion: switch to the SPDX notation on as the license note in the
> header of the files. This achieves minimal footprint in a machine and human
> recognizable format using a standard format (for some definition of
> standard).
>
> Random(ish) example: cmd_fdt.c
> <http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=common/cmd_fdt.c;h=dc59fab8280dc57f0ae546ad552215dea0d99774;hb=HEAD>
>
> References:
>
>    - http://spdx.org/about-spdx
>    - http://spdx.org/licenses/
>    - http://spdx.org/SPDX-specifications/spdx-version-1.2
>
>     To be minimalist, from what I read there thought, we could also
> accept minimal header with license like this
>
> # Copyright 2015 <author>
> # <notice where to find full licence>
>
> (with full license in __openerp__.py for exemple)
>  Exemple here [2]
>
> Agreed, but I would use the SPDX notation in the header to make it
> standard(ish) and scannable.
>
>
>  Our options:
>  a. We keep full header on each source file. And accept only this one.
>
>  b. We define a minimal header template like this as an altenative
> (mostly taken from David Beal's proposal):
>
> # -*- coding: utf-8 -*-# Author: <author name># Copyright 2015 <company or author>
> # License AGPL version 3 or later# See license in __openerp__.py or http://www.gnu.org/licenses/agpl-3.0.txt
>
>
>
>
> [1] More talks about it in:
> https://github.com/OCA/product-attribute/pull/34
>
>  [2] An exemple of minimal license:
> https://github.com/OCA/carrier-delivery/pull/35/files
>
>  Cheers,
>
>   Yannick Vaucher
>  Business Solutions Software Developer
>
>  Camptocamp SA
> PSE A, CH-1015 Lausanne
> Phone: +41 21 619 10 30
> Office: +41 21 619 10 10
> http://www.camptocamp.com/
>
>
> Best regards,
> gvb
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>