← Back to team overview

openstack team mailing list archive

Re: Review days for nova-core members


Soren Hansen wrote:
> 2011/2/22 Ken Pepple <ken.pepple@xxxxxxxxxxxxxx>:
>> having said that, i understand what you are trying to do.
>> so, as a counter proposal, can we implement a round-robin or smart routing (based on file names or modules) reviewer assignment ?
>> failing that, could we assign everything to ttx (sorry) and he can assign reviewers ?
> Or, if there's a designated reviewer each day, that designated
> reviewer could do the first review and assign someone else to do
> another review.

Right, I think it's easier to keep nova-core assigned by default. People
knowing the local expert can specifically add his name to the reviewers,
or the first reviewer can do it.

Forcing adding a specific reviewer has two drawbacks in my opinion:

- some people will end up being called on reviews all the time, being
the expert in too many things
- some areas don't have a local expert, and for efficient round robin
they should probably be left assigned to nova-core


Thierry Carrez (ttx)
Release Manager, OpenStack