← Back to team overview

openstack team mailing list archive

Re: Gerrit minimum review time frame

 

On Tue, Mar 13, 2012, Mark McLoughlin <markmc@xxxxxxxxxx> wrote:
> On Mon, 2012-03-12 at 17:57 -0500, Josh Kearney wrote:
> > Is this is really a problem that needs solving? I'd like to believe that no
> > member of Nova Core would approve something that they aren't familiar with.
> 
> I think the issue is more a case of allowing some time for other
> reviewers to come along and catch issues before it gets merged.

And what's the problem if an occasional issue gets missed?

> Sometimes there can be a few folks working through an issue together and
> the patch gets pushed and approved so quickly that no-one else gets a
> chance to review.

Everyone has an opportunity to review even after a patch gets merged.

JE



References