openstack team mailing list archive

[Gabriel Hurley <Gabriel.Hurley@xxxxxxxxxx>]

I understand the sentiment that leads one to want "minimum" review times; there have been occasions where it's frustrated me that something I objected to got merged without my seeing it or while I was trying to comment.

However, I'd like to present several arguments against a minimum review time:

  1. If you don't trust the judgment of everyone with the commit bit then you've already got a problem that a minimum time won't solve.
  2. There are good (and getting better) gating mechanisms in place to prevent truly broken code from being merged.
  3. You can always propose improvements to code you don't like.
  4. Impeding development by an arbitrary time restriction is discouraging to developers.

And in the end, it comes down to this: the "right" amount of time is not a fixed quantity.

This is a problem to be solved by leadership and community management--particularly in setting expectations for core reviewers behavior--not automated barriers.

    - Gabriel

> -----Original Message-----
> From: openstack-bounces+gabriel.hurley=nebula.com@xxxxxxxxxxxxxxxxxxx
> [mailto:openstack-
> bounces+gabriel.hurley=nebula.com@xxxxxxxxxxxxxxxxxxx] On Behalf Of
> Johannes Erdfelt
> Sent: Tuesday, March 13, 2012 12:45 PM
> To: openstack@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Openstack] Gerrit minimum review time frame
> 
> On Tue, Mar 13, 2012, Lorin Hochstein <lorin@xxxxxxxxxxxxxxxxxx> wrote:
> > As long as we're talking about review issues, I'd really like to have
> > a set of reviewing guidelines. Even better would be to have them in
> > checklist form to make sure we don't miss things as we do reviews
> > (checklists are great: http://gawande.com/the-checklist-manifesto).
> 
> Do you have any examples of things that should be checked?
> 
> I was trying to come up with some but they're in the process of being
> automated now anyway. As a result I'm not sure what would end up on this
> checklist that isn't better automated.
> 
> JE
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp