randgen team mailing list archive

[Matthias Leich <matthias.leich@xxxxxxxxxx>]

Hi Philip,

Am 27.01.2011 12:49, schrieb Philip Stoev:
> I intend to remove the following grammars
> 
> === removed file 'conf/replication/replication-5.1.zz'
> === removed file 'conf/replication/replication-6.0.zz'
> === removed file 'conf/replication/replication.yy'
> === removed file 'conf/replication/replication_innodb_myisam.zz'
> === removed file 'conf/replication/replication_simple.yy'
> === removed file 'conf/replication/replication_single_engine.zz'
> === removed file 'conf/replication/replication_single_engine_pk.zz'
> 
> which were basically half-baked stuff derived from example.yy that
> either does not test anything in particular, or produce statements that
> are meaningless or unsafe for replication. If you are running any of
> those grammars or ZZ files, stop, because they are likely to provide a
> false sense of security.

I agree with your judgement about the current value/effectivity of most
of the grammars above.
But please do not remove any of them until we have sorted out
what to do with automatic runs which use some of them.
Example:  replication_simple.yy is used within some test for semisync
          replication.
As soon as we have found a more challenging/false alarm free replacement
for such grammars + know how good the replacement works with the server
we can remove the old grammar.

> 
> I have fixed some of the bit rot in replication-dml* , and I will push
> shortly.

great, thank you

> 
> I will not be touching any files that have a MySQL WorkLog number. In
> general, if you want to prevent a particular grammar from being edited
> by me, please use "oracle" in the file name and mention your
> requirements promptly at the top of the grammar file.

Sounds good

Thank you

Matthias

> 
> Thank you and let me know if you have any concerns.
> 
> Philip Stoev
> 
> 
> ----- Original Message ----- From: "John H. Embretsen" <johnemb@xxxxxxxxx>
> To: <randgen@xxxxxxxxxxxxxxxxxxx>
> Sent: Wednesday, January 19, 2011 1:21 PM
> Subject: Re: [Randgen] Issues with the replication grammars
> 
> 
>> On 01/19/11 11:39, Matthias Leich wrote:
>>> Hi Philip,
>>>
>>> Am 19.01.2011 09:50, schrieb Philip Stoev:
>>
>>>> So, unless you have any other plans, I plan to spend some time helping
>>>> those tests produce more binlog events. This in turn means that the
>>>> changes I will push may cause any automated runs of those tests that
>>>> you
>>>> currently have to start failing due to issues that are currently not
>>>> detected.
>>>
>>> AFAIR there is some delay between the push of updated grammars to RQG
>>> and their use in automatic runs. So we have a chance to detect and fix
>>> such problems. John will know better,
>>
>> Yes, there is a chance to detect issues before they reach the
>> automated environment, but there is of course no guarantee. We don't
>> use that many replication grammars in automated runs currently, so the
>> impact won't be too heavy.
>>
>> In general, changes to these grammars that will expose more issues
>> than currently, as long as they are legitimate issues, will be a good
>> thing.
>>
>> Thank you for letting us know about these potential changes, Philip.
>>
>>
>> -- 
>> John
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~randgen
>> Post to     : randgen@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~randgen
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~randgen
> Post to     : randgen@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~randgen
> More help   : https://help.launchpad.net/ListHelp


-- 
Matthias Leich
Senior QA Developer
Office: +49 30 4764614

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven