ubuntu-appstore-developers team mailing list archive

[Jamie Strandboge <jamie@xxxxxxxxxxxxx>]

On 08/20/2013 12:43 PM, Sergio Schvezov wrote:
> On Tue, Aug 20, 2013 at 2:13 PM, Jamie Strandboge <jamie@xxxxxxxxxxxxx
> <mailto:jamie@xxxxxxxxxxxxx>> wrote:
> 
>     On 08/16/2013 07:26 AM, Daniel Holbach wrote:
>     > Hello everybody,
>     >
>     > with the appstore opening in alpha stage soon, it's important we figure
>     > out how the reviews are going to take place until we have the process
>     > more automated. This will be a good learning experience for us, what we
>     > can automate, what common problems are, how much time it all takes and
>     > where across all teams needs to be fixed to make things scale up to
>     > bazillions of apps.
>     >
>     ...
>     > It should be interesting to rotate the duty, take notes on
>     >
>     >   https://wiki.ubuntu.com/AppStore/Decisions/ReviewRequirements
>     >
>     > and collect tips, improve our review notes and script what we can to
>     > have the process automated in the near future.
>     >
>     > Even though automating the review process is the immediate goal, I'm
>     > sure this learning experience is going to help in the larger project, so
>     > SDK bits can be improved, and many other bits and pieces as well.
> 
>     I didn't put this in the wiki, but could. I noticed when doing my first reviews
>     a few things:
>      * 'click build' creates a package which is 'Architecture: all' and a package
>        name with *_all.click even if the package has compiled code (LP: #1214380).
>        Seems like this might be part of the fat package discussion, but as it
>        stands now, the appstore doesn't support compiled code-- eg, a developer
>        could upload something for i386 but it wouldn't work on armhf. This seems to
>        be planned for August based on the wiki[1]
> 
> 
> You should be able to add "Architecure": "armhf" into the manifest.
> 

The click manifest supports "architecture"? This is not documented in the
upstream documentation:
http://bazaar.launchpad.net/~click-hackers/click/trunk/view/head:/doc/file-format.rst

>      * one of the packages I reviewed does not have a package name of the form of:
>        $pkgname_$version_$arch.click. Not sure why that is, 'click build' should do
>        this for people.
> 
> You can always rename a click file.

Sure and I made adjustments to the review tools to examine DEBIAN/control to get
the package name, version and architecture. There are lint checks to verify name
and version against the manifest.

But I left the lint check to verify the package name because it we should
require best practices for the appstore and we don't want people creating
safe-app.click when it installs to com.ubuntu.badapp or similar. There is no
reason to rename the package when the SDK is doing it right (and I verified it is).


-- 
Jamie Strandboge                 http://www.ubuntu.com/

Attachment: signature.asc
Description: OpenPGP digital signature