ubuntu-touch-coreapps team mailing list archive

[Stefano Verzegnassi <stefano92.100@xxxxxxxxx>]

Hi,

I've created a new branch for poppler-qml-plugin:
http://bazaar.launchpad.net/~verzegnassi-stefano/poppler-qml-plugin/use-qabstractlistmodel

This includes a new ListModel and a Worker Thread, in order to load 
pages asynchronously.
Sadly the code is not backward compatible with the earlier revisions, 
and it requires some changes in docviewer-app trunk.

If you want to test it, I've uploaded an example project[1] with a dummy 
PDF files. The Poppler plugin is already built-in.

Any feedback or advice would be very appreciated. Once everything is ok, 
I'll propose it for merging.


Cheers,
Stefano

[1] 
https://code.launchpad.net/~verzegnassi-stefano/+junk/poppler-qml-with-listmodel-example

Il 08/10/2014 09:13, David Planella ha scritto:
> On Wed, Oct 8, 2014 at 9:10 AM, David Planella
> <david.planella@xxxxxxxxxx <mailto:david.planella@xxxxxxxxxx>> wrote:
>
>     Hi all,
>
>     After a quick e-mail conversation with Fabio, I gave a go at using
>     his branch as a basis and finish off the integration of the plugin.
>     I'll need to adapt the autopilot tests, but in the meantime, the
>     code changes in the app+plugin should be finished. If someone could
>     throw it a review, that'd be great.
>
>     https://code.launchpad.net/~fcole90/ubuntu-docviewer-app/include-file-plugin/+merge/237543
>     <https://code.launchpad.net/%7Efcole90/ubuntu-docviewer-app/include-file-plugin/+merge/237543>
>
>
> Sorry, correct link now:
>
> https://code.launchpad.net/~dpm/ubuntu-docviewer-app/add-plugin/+merge/237545
>
>
>     Thanks!
>
>     Cheers,
>     David.
>
>
>     On Tue, Oct 7, 2014 at 5:10 PM, David Planella
>     <david.planella@xxxxxxxxxx <mailto:david.planella@xxxxxxxxxx>> wrote:
>
>         Hi all,
>
>         I'll say it again: it's great to see the docviewer development
>         catching up again!
>
>         Fabio, I see you started the branch to include the file plugin
>         inside the app's source tree, but there is no merge proposal
>         yet. Is the branch ready for review? Is there anything you need
>         help with?
>
>         https://code.launchpad.net/~fcole90/ubuntu-docviewer-app/include-file-plugin
>
>         Thanks!
>
>         Cheers,
>         David.