widelands-dev team mailing list archive

[kaputtnik <somal@xxxxxxxx>]

kaputtnik has proposed merging lp:~widelands-dev/widelands/bug_1736095_improve_text_for_resources_height into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1736095 in widelands: "Editor: Improve texts for resources tool"
  https://bugs.launchpad.net/widelands/+bug/1736095

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug_1736095_improve_text_for_resources_height/+merge/335130

Changed texts for editor place resources and set height.

There is one thing with place resource: The text "Increase/Decrease Amount by:" breaks after "Amount" and is shown now in two rows.

And i am not sure if "Amount" should be uppercase.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_1736095_improve_text_for_resources_height into lp:widelands.

=== modified file 'src/editor/ui_menus/tool_change_height_options_menu.cc'
--- src/editor/ui_menus/tool_change_height_options_menu.cc	2017-02-25 11:17:28 +0000
+++ src/editor/ui_menus/tool_change_height_options_menu.cc	2017-12-13 11:01:35 +0000
@@ -44,7 +44,7 @@
                 increase_tool_.get_change_by(),
                 1,
                 MAX_FIELD_HEIGHT_DIFF,
-                _("Increase/Decrease Value:"),
+                _("Increase/Decrease Height by:"),
                 UI::SpinBox::Units::kNone,
                 g_gr->images().get("images/ui_basic/but1.png"),
                 UI::SpinBox::Type::kSmall),
@@ -56,7 +56,7 @@
              increase_tool_.set_tool().get_interval().min,
              0,
              MAX_FIELD_HEIGHT,
-             _("Set Value:"),
+             _("Set Height to:"),
              UI::SpinBox::Units::kNone,
              g_gr->images().get("images/ui_basic/but1.png"),
              UI::SpinBox::Type::kSmall) {

=== modified file 'src/editor/ui_menus/tool_change_resources_options_menu.cc'
--- src/editor/ui_menus/tool_change_resources_options_menu.cc	2017-09-01 15:45:59 +0000
+++ src/editor/ui_menus/tool_change_resources_options_menu.cc	2017-12-13 11:01:35 +0000
@@ -57,7 +57,7 @@
                 increase_tool_.get_change_by(),
                 1,
                 kMaxValue,
-                _("Increase/Decrease Value:"),
+                _("Increase/Decrease Amount by:"),
                 UI::SpinBox::Units::kNone,
                 g_gr->images().get("images/ui_basic/but1.png"),
                 UI::SpinBox::Type::kSmall),
@@ -69,7 +69,7 @@
              increase_tool_.set_tool().get_set_to(),
              0,
              kMaxValue,
-             _("Set Value:"),
+             _("Set Amount to:"),
              UI::SpinBox::Units::kNone,
              g_gr->images().get("images/ui_basic/but1.png"),
              UI::SpinBox::Type::kSmall),
@@ -82,7 +82,7 @@
 	     "Shift + Click on the map to decrease the amount of the selected resource"));
 	set_to_.set_tooltip(
 	   /** TRANSLATORS: Editor set rseources access key. **/
-	   _("Ctrl + Click on the map to set the amount of the selected resource"));
+	   _("Ctrl + Click on the map to set the amount of the selected resource. This replaces already set resources"));
 
 	change_by_.changed.connect(
 	   boost::bind(&EditorToolChangeResourcesOptionsMenu::update_change_by, boost::ref(*this)));