yade-dev team mailing list archive
-
yade-dev team
-
Mailing list archive
-
Message #03588
Re: [Branch ~yade-dev/yade/trunk] Rev 2069: NEW TRY to add the updated version of cohesiveFrictionalContactLaw called cohesiveFrictionalPM (s...
> Yes, you are totally right. In fact, I was expecting some criticisms
> because the code does exactly what cohesiveFrictionalContactLaw does.
> The idea was to have an updated version of the code with all the
> components in the same sources files (say,
> cohesiverictionalRelationships and all this things), because, as I
> read in a lot of messages sent to the mailing list,
> cohesiveFrictionalContactLaw is a "real mess" (this term is not
> mine ;) ). I think I have introduced some of the comments needed to
> understand its usefulness as you suggested with YADE_CLASS_BASE_DOC,
> with almost all the parameters defined. You can also notice that I
> gave a reference to a paper for the definition of the frictional part
> of the law inside the "Global Overview" part. In this (my) sense, I
> thought this new version of cohesiveFrictionalContactLaw was more
> clearer, but if you prefer to keep the older version, just remove
> mine, I just did the commit to help...
Sorry for being too harsh, now I understand it is a cleaner version of
the older one. If people using the older CohesiveFrictionalLaw agree, I
would like to remove the old one. I will update the *_DOC so that the
reference to paper is in the comment that appears on the web, if you
agree. The /* comments */ don't show up anywhere, except for doxygen,
which is almost unused now.
Cheers, Vaclav
References