← Back to team overview

yade-users team mailing list archive

Re: [Question #234450]: Law2_ScGeom_ViscElPhys_Basic

 

On 08/22/2013 05:49 PM, Bruno Chareyre wrote:
> Hi,
> I discussed that with Raphael before and I was not sure it was worth
> keeping the existing equations.
> One reason is it is listed red here:
> https://yade-dem.org/wiki/ConstitutiveLaws (i.e. no user and no
> maintainer...)

Oops, it is really working code and I am using it and adding there
sometimes new features.

> I'm glad to hear that somebody can vouch for the current code and that
> it corresponds to a published model (it would be nice to mention it in
> the documentation).

It is mentioned here [1] in getViscoelasticFromSpheresInteraction, but
you are right, it should be added directly into the contact law. I will
take care about that.

> @Anton, do you recommend "diff" or "git format-patch"?

It does not really matter. But, please, do "incremental" commits e.g.
one change per commit. It is not a good idea to have one large patch.
So, probably, format-patch will be better.


[1]
https://www.yade-dem.org/doc/yade.utils.html?highlight=getviscoelasticfromspheresinteraction#yade._utils.getViscoelasticFromSpheresInteraction


Attachment: signature.asc
Description: OpenPGP digital signature


References